From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Type Checking Improvements
Date: Fri, 18 Jul 2025 18:19:00 +0200 [thread overview]
Message-ID: <20250718161905.461482-1-m.carrara@proxmox.com> (raw)
Type Checking Improvements - v1
===============================
The pyVmomi (python3-pyvmomi) package received a bunch of new type stubs
in trixie. This series adds explicit type hints where applicable. Note
that because pyVmomi uses a lot of `Optional[Something]` types, which is
quite a nuisance to handle in this regard (as you'll see in patch 01).
Because of these new type stubs we no longer have to ignore missing
imports regarding pyVmomi in mypy.ini and can add it as a build
dependency for mypy's sake. This also eliminates any quirks around mypy
not linting anything regarding pyVmomi types if python3-pyvmomi isn't
installed.
Gave the script a quick smoke test by calling it directly towards a
local ESXi instance I still had lying around to check if I didn't break
anything by accident.
Summary of Changes
------------------
Max R. Carrara (5):
listvms: respect new type hints of pyVmomi package
listvms: s/EsxiConnectonArgs/EsxiConnectionArgs
listvms: run formatter
d/control: add python3-pyvmomi (>= 8) as build dependency
.gitignore: ignore .lint-incremental
.gitignore | 1 +
debian/control | 1 +
listvms.py | 114 +++++++++++++++++++++++++++++++++++++++----------
mypy.ini | 3 --
4 files changed, 94 insertions(+), 25 deletions(-)
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-07-18 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 16:19 Max R. Carrara [this message]
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 1/5] listvms: respect new type hints of pyVmomi package Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 2/5] listvms: s/EsxiConnectonArgs/EsxiConnectionArgs Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 3/5] listvms: run formatter Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 4/5] d/control: add python3-pyvmomi (>= 8) as build dependency Max R. Carrara
2025-07-18 16:19 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 5/5] .gitignore: ignore .lint-incremental Max R. Carrara
2025-07-22 20:14 ` [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Type Checking Improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718161905.461482-1-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.