From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] refuse to migrate volume-chain-snapshots for now
Date: Fri, 18 Jul 2025 13:56:10 +0200 [thread overview]
Message-ID: <20250718115626.183425-1-w.bumiller@proxmox.com> (raw)
When using qcow2 "backing volumes" for snapshots we'd have to copy all
of them for local-storage migration. Let's refuse to do this for now
and wait until we decide whether this should also happen via
replication at some point.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---
src/PVE/QemuMigrate.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
index f46bdf40..251fcc79 100644
--- a/src/PVE/QemuMigrate.pm
+++ b/src/PVE/QemuMigrate.pm
@@ -454,6 +454,10 @@ sub scan_local_volumes {
# we cannot migrate snapshots on local storage
# exceptions: 'zfspool' or 'qcow2' files (on directory storage)
+ #
+ # Note that only qcow2 with in-qcow2 snapshots work - for
+ # backing-chain snapshots we'd need to copy the entire snapshot
+ # list (or support replication)
die "online storage migration not possible if non-replicated snapshot exists\n"
if $self->{running} && !$local_volumes->{$volid}->{replicated};
@@ -464,7 +468,8 @@ sub scan_local_volumes {
if (!(
$scfg->{type} eq 'zfspool'
|| ($scfg->{type} eq 'btrfs' && $local_volumes->{$volid}->{format} eq 'raw')
- || $local_volumes->{$volid}->{format} eq 'qcow2'
+ || ($local_volumes->{$volid}->{format} eq 'qcow2'
+ && !$scfg->{'snapshot-as-volume-chain'})
)) {
die "non-migratable snapshot exists\n";
}
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-07-18 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 11:56 Wolfgang Bumiller [this message]
2025-07-18 12:30 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718115626.183425-1-w.bumiller@proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.