* [pve-devel] [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window @ 2025-07-17 12:06 Gabriel Goller 2025-07-17 12:06 ` [pve-devel] [PATCH pve-manager 2/2] fabrics: add emptyText attributes to some input fields Gabriel Goller 2025-07-17 21:28 ` [pve-devel] applied-series: [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window Thomas Lamprecht 0 siblings, 2 replies; 3+ messages in thread From: Gabriel Goller @ 2025-07-17 12:06 UTC (permalink / raw) To: pve-devel; +Cc: Thomas Lamprecht Increase the width of the OSPF and OpenFabric add and create windows. This looks more pleasant and the input fields aren't that crammed anymore. Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Gabriel Goller <g.goller@proxmox.com> --- www/manager6/sdn/fabrics/FabricEdit.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js index 3248dc4ce12a..5aa001564175 100644 --- a/www/manager6/sdn/fabrics/FabricEdit.js +++ b/www/manager6/sdn/fabrics/FabricEdit.js @@ -2,6 +2,8 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { extend: 'Proxmox.window.Edit', mixins: ['Proxmox.Mixin.CBind'], + width: 400, + fabricId: undefined, baseUrl: '/cluster/sdn/fabrics/fabric', -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] [PATCH pve-manager 2/2] fabrics: add emptyText attributes to some input fields 2025-07-17 12:06 [pve-devel] [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window Gabriel Goller @ 2025-07-17 12:06 ` Gabriel Goller 2025-07-17 21:28 ` [pve-devel] applied-series: [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window Thomas Lamprecht 1 sibling, 0 replies; 3+ messages in thread From: Gabriel Goller @ 2025-07-17 12:06 UTC (permalink / raw) To: pve-devel; +Cc: Thomas Lamprecht Add default emptyText attributes to OpenFabric and OSPF add/edit windows. Use the default values on Hello Interval [0], CSNP Interval [1] and Hello Multiplier [2] inputs. For the OSPF area just use the simplest area "0" (the backbone). [0]: https://github.com/FRRouting/frr/blob/f56119ea0321ee7d149172422a6d87e106a94778/isisd/isis_constants.h#L77 [1]: https://github.com/FRRouting/frr/blob/f56119ea0321ee7d149172422a6d87e106a94778/isisd/isis_constants.h#L69 [2]: https://github.com/FRRouting/frr/blob/f56119ea0321ee7d149172422a6d87e106a94778/isisd/isis_constants.h#L81 Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Gabriel Goller <g.goller@proxmox.com> --- www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 2 ++ www/manager6/sdn/fabrics/openfabric/InterfacePanel.js | 1 + www/manager6/sdn/fabrics/ospf/FabricEdit.js | 1 + 3 files changed, 4 insertions(+) diff --git a/www/manager6/sdn/fabrics/openfabric/FabricEdit.js b/www/manager6/sdn/fabrics/openfabric/FabricEdit.js index 9da624190bc6..46dd61c410aa 100644 --- a/www/manager6/sdn/fabrics/openfabric/FabricEdit.js +++ b/www/manager6/sdn/fabrics/openfabric/FabricEdit.js @@ -47,6 +47,7 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.Fabric.Edit', { labelWidth: 120, name: 'hello_interval', allowBlank: true, + emptyText: '3', skipEmptyText: true, cbind: { deleteEmpty: '{!isCreate}', @@ -58,6 +59,7 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.Fabric.Edit', { labelWidth: 120, name: 'csnp_interval', allowBlank: true, + emptyText: '10', skipEmptyText: true, cbind: { deleteEmpty: '{!isCreate}', diff --git a/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js b/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js index fbc2a27d8c9e..f23b889b4687 100644 --- a/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js +++ b/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js @@ -24,6 +24,7 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.InterfacePanel', { widget: { xtype: 'proxmoxintegerfield', isFormField: false, + emptyText: '10', bind: { disabled: '{record.isDisabled}', }, diff --git a/www/manager6/sdn/fabrics/ospf/FabricEdit.js b/www/manager6/sdn/fabrics/ospf/FabricEdit.js index c27c6eb4458d..4c4e17c99090 100644 --- a/www/manager6/sdn/fabrics/ospf/FabricEdit.js +++ b/www/manager6/sdn/fabrics/ospf/FabricEdit.js @@ -14,6 +14,7 @@ Ext.define('PVE.sdn.Fabric.Ospf.Fabric.Edit', { fieldLabel: gettext('Area'), labelWidth: 120, name: 'area', + emptyText: '0', allowBlank: false, }, ], -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied-series: [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window 2025-07-17 12:06 [pve-devel] [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window Gabriel Goller 2025-07-17 12:06 ` [pve-devel] [PATCH pve-manager 2/2] fabrics: add emptyText attributes to some input fields Gabriel Goller @ 2025-07-17 21:28 ` Thomas Lamprecht 1 sibling, 0 replies; 3+ messages in thread From: Thomas Lamprecht @ 2025-07-17 21:28 UTC (permalink / raw) To: pve-devel, Gabriel Goller On Thu, 17 Jul 2025 14:06:38 +0200, Gabriel Goller wrote: > Increase the width of the OSPF and OpenFabric add and create windows. > This looks more pleasant and the input fields aren't that crammed > anymore. > > Applied, thanks! [1/2] fabric: increase width of fabric edit/add window commit: dd734f2496a4ca755a73646d8b811bd0b6e8e91b [2/2] fabrics: add emptyText attributes to some input fields commit: 2a13a2e5d9818fe00d779970740a9d98ae2cafcf _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-17 21:29 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2025-07-17 12:06 [pve-devel] [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window Gabriel Goller 2025-07-17 12:06 ` [pve-devel] [PATCH pve-manager 2/2] fabrics: add emptyText attributes to some input fields Gabriel Goller 2025-07-17 21:28 ` [pve-devel] applied-series: [PATCH pve-manager 1/2] fabric: increase width of fabric edit/add window Thomas Lamprecht
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.