From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network v2 1/1] controllers: isis: add altname support
Date: Wed, 16 Jul 2025 17:18:13 +0200 [thread overview]
Message-ID: <20250716151815.348161-7-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250716151815.348161-1-s.hanreich@proxmox.com>
Since this only has an effect on applying the configuration, users
will still need to reapply the configuration when an interface changes
names / altnames. In order to add full altname support for IS-IS,
altname support would need to be implemented in FRR.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
Notes:
Gabriel is currently working on altname support in FRR [1]
[1] https://github.com/FRRouting/frr/pull/19156
src/PVE/Network/SDN/Controllers/IsisPlugin.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm
index 6e3574d..0ef9fb9 100644
--- a/src/PVE/Network/SDN/Controllers/IsisPlugin.pm
+++ b/src/PVE/Network/SDN/Controllers/IsisPlugin.pm
@@ -80,9 +80,12 @@ sub generate_controller_config {
my @iface_config = ("ip router isis $isis_domain");
+ my $altnames = PVE::Network::altname_mapping();
+
my @ifaces = PVE::Tools::split_list($isis_ifaces);
for my $iface (sort @ifaces) {
- push(@{ $config->{frr_interfaces}->{$iface} }, @iface_config);
+ my $iface_name = $altnames->{$iface} // $iface;
+ push(@{ $config->{frr_interfaces}->{$iface_name} }, @iface_config);
}
return $config;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-16 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 15:18 [pve-devel] [RFC common/firewall/manager/network/proxmox{-ve-rs, -firewall} v2 0/8] NIC renaming mitigations Stefan Hanreich
2025-07-16 15:18 ` [pve-devel] [PATCH pve-common v2 1/2] network: add ip link and altname helpers Stefan Hanreich
2025-07-16 15:18 ` [pve-devel] [PATCH pve-common v2 2/2] network: add nic prefix to physical nic regex Stefan Hanreich
2025-07-16 15:18 ` [pve-devel] [PATCH proxmox-ve-rs v2 1/1] config: ip link struct Stefan Hanreich
2025-07-16 15:18 ` [pve-devel] [PATCH proxmox-firewall v2 1/1] firewall: add altname support for firewall rules Stefan Hanreich
2025-07-16 15:18 ` [pve-devel] [PATCH pve-firewall v2 1/1] firewall: add altname support Stefan Hanreich
2025-07-16 15:18 ` Stefan Hanreich [this message]
2025-07-16 15:18 ` [pve-devel] [PATCH pve-manager v2 1/2] cli: add proxmox-network-interface-pinning tool Stefan Hanreich
2025-07-16 15:18 ` [pve-devel] [PATCH pve-manager v2 2/2] services: add pvesdncommit and pvefirewallcommit Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716151815.348161-7-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.