From: Hannes Duerr <h.duerr@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-storage] RBDPlugin: add missing check for external ceph cluster
Date: Wed, 16 Jul 2025 13:43:37 +0200 [thread overview]
Message-ID: <20250716114337.58432-1-h.duerr@proxmox.com> (raw)
In this commit [0] the ceph config creation was packed into a new
function and checked whether the installation is an external Ceph
cluster or not. However, a check was forgotten in the RBDPlugin which we
are now adding.
Without this check a configuration in /etc/pve/priv/ceph/<pool>.conf is
created and pvestatd complains
pvestatd[1144]: ignoring custom ceph config for storage 'pool', 'monhost' is not set (assuming pveceph managed cluster)! because the file /etc/pve/priv/ceph/pool.conf
[0] https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=7684225baccf0de07504ac21a25cbf576d60a766
Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
---
src/PVE/Storage/RBDPlugin.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index ce7db50..bf2e358 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBDPlugin.pm
@@ -457,8 +457,12 @@ sub options {
sub on_add_hook {
my ($class, $storeid, $scfg, %param) = @_;
+ my $pveceph_managed = !defined($scfg->{monhost});
+
PVE::CephConfig::ceph_create_keyfile($scfg->{type}, $storeid, $param{keyring});
- PVE::CephConfig::ceph_create_configuration($scfg->{type}, $storeid);
+
+ PVE::CephConfig::ceph_create_configuration($scfg->{type}, $storeid) if (!$pveceph_managed);
+
return;
}
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-07-16 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 11:43 Hannes Duerr [this message]
2025-07-16 12:10 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716114337.58432-1-h.duerr@proxmox.com \
--to=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.