From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] auto: tests: fix up lvm swapsize test after heuristic change
Date: Tue, 15 Jul 2025 15:43:49 +0200 [thread overview]
Message-ID: <20250715134403.962663-1-c.heiss@proxmox.com> (raw)
The heuristic was changed in the commit mentioned below, the respective
test needs adjustment too.
Fixes: 08136f8 ("avoid artificial limit and allow using up to half of hdsize as swap")
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
.../parse_answer_fail/lvm_swapsize_greater_than_hdsize.json | 2 +-
.../parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
index aa4f7fe..e0e59c5 100644
--- a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
+++ b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
@@ -1,3 +1,3 @@
{
- "error": "Swap size 4.01 GiB cannot be greater than 4 GiB (hard disk size / 8)"
+ "error": "Swap size 16.01 GiB cannot be greater than 16 GiB (hard disk size / 2)"
}
diff --git a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
index ffe16dc..22a7f6b 100644
--- a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
+++ b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
@@ -11,6 +11,6 @@ source = "from-dhcp"
[disk-setup]
filesystem = "ext4"
-lvm.swapsize = 4.01
+lvm.swapsize = 16.01
lvm.hdsize = 32
disk-list = ["sda"]
--
2.49.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-07-15 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 13:43 Christoph Heiss [this message]
2025-07-15 13:55 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715134403.962663-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.