[pve-devel] [PATCH v3] fix #5894: pvestatd: improve broadcast of node version-info

[pve-devel] [PATCH v3] fix #5894: pvestatd: improve broadcast of node version-info

[Aaron Lauterer]

Until now, the pvestatd did broadcast the pve-manager version only once
after startup of the service. But there are some situations, where the
local pmxcfs (pve-cluster) restarts and loses that information.
Basically everytime we restart the pmxcfs without restarting pvestatd
too.

For example, on a cluster join, or if the pmxcfs has been restarted
manually.

By additionally checking if the local kv-store of the pmxcfs has any
version info for the node, we can decide if another broadcast is
necessary.
Therefore after the next run of pvestatd, we should have the full
version info available again.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---

Notes:
    changes since
    v2:
    * rebased
    v1:
    * use scalar() around check if keys are present
    * mention bug this fixes

 PVE/Service/pvestatd.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index e3ea06bb..e645eec3 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -601,7 +601,10 @@ sub update_sdn_status {
 
 my $broadcast_version_info_done = 0;
 my sub broadcast_version_info : prototype() {
-    if (!$broadcast_version_info_done) {
+    if (
+        !$broadcast_version_info_done
+        || !scalar(keys PVE::Cluster::get_node_kv('version-info', $nodename)->%*)
+    ) {
         PVE::Cluster::broadcast_node_kv(
             'version-info', encode_json(PVE::pvecfg::version_info()),
         );
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v3] fix #5894: pvestatd: improve broadcast of node version-info

[Thomas Lamprecht]

On Mon, 14 Jul 2025 10:23:58 +0200, Aaron Lauterer wrote:
> Until now, the pvestatd did broadcast the pve-manager version only once
> after startup of the service. But there are some situations, where the
> local pmxcfs (pve-cluster) restarts and loses that information.
> Basically everytime we restart the pmxcfs without restarting pvestatd
> too.
> 
> For example, on a cluster join, or if the pmxcfs has been restarted
> manually.
> 
> [...]

Applied, with fleecing in some background for the cases for when this was not
problematic (restarts through pve-cluster updates) to have a more complete
view, thanks!

[1/1] fix #5894: pvestatd: improve broadcast of node version-info
      commit: 85d237042b51da066ff1970ff269c3b5b609ba71


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel