[pve-devel] [PATCH manager] api: use 'number' instead of 'amount' for countable nouns

[pve-devel] [PATCH manager] api: use 'number' instead of 'amount' for countable nouns

[Lukas Wagner]

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 PVE/API2/Cluster.pm | 4 ++--
 PVE/API2/Tasks.pm   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index a025d264..cda34bb3 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -364,7 +364,7 @@ __PACKAGE__->register_method({
                 },
                 diskread => {
                     description =>
-                        "The amount of bytes the guest read from its block devices since"
+                        "The number of bytes the guest read from its block devices since"
                         . " the guest was started. This info is not available for all storage types."
                         . " (for types 'qemu' and 'lxc')",
                     type => 'integer',
@@ -373,7 +373,7 @@ __PACKAGE__->register_method({
                 },
                 diskwrite => {
                     description =>
-                        "The amount of bytes the guest wrote to its block devices since"
+                        "The number of bytes the guest wrote to its block devices since"
                         . " the guest was started. This info is not available for all storage types."
                         . " (for types 'qemu' and 'lxc')",
                     type => 'integer',
diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index 9da5b6bd..d65663f6 100644
--- a/PVE/API2/Tasks.pm
+++ b/PVE/API2/Tasks.pm
@@ -63,7 +63,7 @@ __PACKAGE__->register_method({
                 minimum => 0,
                 default => 50,
                 optional => 1,
-                description => "Only list this amount of tasks.",
+                description => "Only list this number of tasks.",
             },
             userfilter => {
                 type => 'string',
@@ -358,7 +358,7 @@ __PACKAGE__->register_method({
                 minimum => 0,
                 default => 50,
                 optional => 1,
-                description => "The amount of lines to read from the tasklog.",
+                description => "The number of lines to read from the tasklog.",
             },
             download => {
                 type => 'boolean',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] api: use 'number' instead of 'amount' for countable nouns

[Lukas Wagner]

On Wed Jul 2, 2025 at 1:49 PM CEST, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  PVE/API2/Cluster.pm | 4 ++--
>  PVE/API2/Tasks.pm   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
> index a025d264..cda34bb3 100644
> --- a/PVE/API2/Cluster.pm
> +++ b/PVE/API2/Cluster.pm
> @@ -364,7 +364,7 @@ __PACKAGE__->register_method({
>                  },
>                  diskread => {
>                      description =>
> -                        "The amount of bytes the guest read from its block devices since"
> +                        "The number of bytes the guest read from its block devices since"
>                          . " the guest was started. This info is not available for all storage types."
>                          . " (for types 'qemu' and 'lxc')",
>                      type => 'integer',
> @@ -373,7 +373,7 @@ __PACKAGE__->register_method({
>                  },
>                  diskwrite => {
>                      description =>
> -                        "The amount of bytes the guest wrote to its block devices since"
> +                        "The number of bytes the guest wrote to its block devices since"
>                          . " the guest was started. This info is not available for all storage types."
>                          . " (for types 'qemu' and 'lxc')",
>                      type => 'integer',
> diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
> index 9da5b6bd..d65663f6 100644
> --- a/PVE/API2/Tasks.pm
> +++ b/PVE/API2/Tasks.pm
> @@ -63,7 +63,7 @@ __PACKAGE__->register_method({
>                  minimum => 0,
>                  default => 50,
>                  optional => 1,
> -                description => "Only list this amount of tasks.",
> +                description => "Only list this number of tasks.",
>              },
>              userfilter => {
>                  type => 'string',
> @@ -358,7 +358,7 @@ __PACKAGE__->register_method({
>                  minimum => 0,
>                  default => 50,
>                  optional => 1,
> -                description => "The amount of lines to read from the tasklog.",
> +                description => "The number of lines to read from the tasklog.",
>              },
>              download => {
>                  type => 'boolean',

bump


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] api: use 'number' instead of 'amount' for countable nouns

[Fabian Grünbichler]

On Wed, 02 Jul 2025 13:49:16 +0200, Lukas Wagner wrote:
> 


Applied, thanks!

[1/1] api: use 'number' instead of 'amount' for countable nouns
      commit: 9a4b04ea49948cff208fe8086ef4c350ae8e9fc2

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel