all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] api: backup: remove unneeded call of rrd_dump
@ 2025-07-01 12:16 Aaron Lauterer
  2025-08-04 18:34 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Aaron Lauterer @ 2025-07-01 12:16 UTC (permalink / raw)
  To: pve-devel

$rrd is never used within this function, therefore we can easily remove
it.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 PVE/API2/Backup.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 42e9c418..27f5a14c 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -667,7 +667,6 @@ __PACKAGE__->register_method({
         my $vzconf = cfs_read_file('vzdump.cron');
         my $all_jobs = $vzconf->{jobs} || [];
         my $job;
-        my $rrd = PVE::Cluster::rrd_dump();
 
         for my $j (@$all_jobs) {
             if ($j->{id} eq $param->{id}) {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] api: backup: remove unneeded call of rrd_dump
  2025-07-01 12:16 [pve-devel] [PATCH manager] api: backup: remove unneeded call of rrd_dump Aaron Lauterer
@ 2025-08-04 18:34 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-08-04 18:34 UTC (permalink / raw)
  To: pve-devel, Aaron Lauterer

On Tue, 01 Jul 2025 14:16:56 +0200, Aaron Lauterer wrote:
> $rrd is never used within this function, therefore we can easily remove
> it.
> 
> 

Applied, thanks!

[1/1] api: backup: remove unneeded call of rrd_dump
      commit: f454b458949e1d66b04eaa84d51128ac4ea82250


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-04 18:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-01 12:16 [pve-devel] [PATCH manager] api: backup: remove unneeded call of rrd_dump Aaron Lauterer
2025-08-04 18:34 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal