From: "Michael Köppl" <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage v8 2/2] parse_volname: print warning if storage does not exists
Date: Thu, 26 Jun 2025 18:06:18 +0200 [thread overview]
Message-ID: <20250626160626.311407-3-m.koeppl@proxmox.com> (raw)
In-Reply-To: <20250626160626.311407-1-m.koeppl@proxmox.com>
To keep behavior around non-existent storages consistent with
vdisk_free(), also print warning if storage does not exist.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/PVE/Storage.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index ec875fd0..ddb8822e 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -529,6 +529,11 @@ sub parse_volname {
my ($storeid, $volname) = parse_volume_id($volid);
my $scfg = storage_config($cfg, $storeid);
+ if (!$scfg) {
+ log_warn(
+ "storage '$storeid' does not exist, mountpoint volume '$volid' could not be deleted");
+ return;
+ }
my $plugin = PVE::Storage::Plugin->lookup($scfg->{type});
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-26 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 16:06 [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH storage v8 1/2] vdisk_free: print warning if underlying storage does not exist Michael Köppl
2025-06-26 16:06 ` Michael Köppl [this message]
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 1/4] fix #3711: warn about storage errors during mountpoint delete Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 2/4] destroy_lxc, delete_mp_volume: rename $volume to $volid Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 3/4] config: ensure valid volid through parse_volume() Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 4/4] add linked clone check when destroying container template Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 1/4] adapt linked clone check to not die if an error occurs during check Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 2/4] fix #3711: make removal of VM possible if store does not exist anymore Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 3/4] destroy_vm: use log_warn for vdisk_free errors for consistency Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 4/4] display warnings for storage errors or if storage no longer exists Michael Köppl
2025-07-08 11:09 ` [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior Lukas Wagner
2025-07-15 16:29 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626160626.311407-3-m.koeppl@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.