[pve-devel] [PATCH installer] unconfigured: add missing [ ] around if clause

[pve-devel] [PATCH installer] unconfigured: add missing [ ] around if clause

[Christoph Heiss]

"-n" would be treated like a command here otherwise.

Fixes: dc36013 ("unconfigured: rework stopping systemd-udevd slightly")
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 unconfigured.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/unconfigured.sh b/unconfigured.sh
index ddab415..caa08c3 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -81,7 +81,7 @@ real_reboot() {
 
     # stop udev (release file handles)
     udevd_pid="$(pgrep systemd-udevd)"
-    if -n "$udevd_pid"; then
+    if [ -n "$udevd_pid" ]; then
         if kill -s TERM "$udevd_pid"; then
             if ! waitpid --exited --timeout 5 "$udevd_pid"; then
                 echo "failed to wait for udevd exit - $?"
-- 
2.49.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH installer] unconfigured: add missing [ ] around if clause

[Thomas Lamprecht]

On Thu, 26 Jun 2025 09:50:46 +0200, Christoph Heiss wrote:
> "-n" would be treated like a command here otherwise.
> 
> 

Applied, thanks!

[1/1] unconfigured: add missing [ ] around if clause
      commit: 190a64e5dd300a9192dfe32d2f28b3589961652c


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel