From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] unconfigured: add missing [ ] around if clause
Date: Thu, 26 Jun 2025 09:50:46 +0200 [thread overview]
Message-ID: <20250626075052.65257-1-c.heiss@proxmox.com> (raw)
"-n" would be treated like a command here otherwise.
Fixes: dc36013 ("unconfigured: rework stopping systemd-udevd slightly")
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
unconfigured.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/unconfigured.sh b/unconfigured.sh
index ddab415..caa08c3 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -81,7 +81,7 @@ real_reboot() {
# stop udev (release file handles)
udevd_pid="$(pgrep systemd-udevd)"
- if -n "$udevd_pid"; then
+ if [ -n "$udevd_pid" ]; then
if kill -s TERM "$udevd_pid"; then
if ! waitpid --exited --timeout 5 "$udevd_pid"; then
echo "failed to wait for udevd exit - $?"
--
2.49.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-06-26 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 7:50 Christoph Heiss [this message]
2025-06-26 11:40 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626075052.65257-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.