From: Lukas Wagner <l.wagner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{,-backup} 00/10] change of default notification-mode; UX improvements
Date: Mon, 23 Jun 2025 16:13:05 +0200 [thread overview]
Message-ID: <20250623141315.288681-1-l.wagner@proxmox.com> (raw)
This is intended for the PBS 4.0 release (trixie based).
This patch series changes the default notification mode for PBS to
'notification-system' from the former default of 'legacy-sendmail'.
The rationale for the new default is:
- 'notification-system' was already used as a default for any datastore
created by the GUI
- consistency, since on PVE, the default is 'auto' (which does not exist
on PBS, but is equivalent to 'notification-system' unless an email
address has been added as well)
- users are gently nudged to use the new notification stack
The new default affects any datastore/tape backup job that has no explicit
value set. The proxmox-backup part of this series contains migration code which
is invoked from d/postinst to migrate users who relied on the old default to
the appropriate explicit setting.
As mentioned above, the GUI already explicitly set the value to the new default
for a long time. As a result, the changed default mostly affects newly created
datastores/tape jobs which were created via third-party API users or the CLI.
This patch series also contains various UX improvements to make the two
notification modes much easier to understand. The approach is generally the
same as in my series for PVE [1].
[1]: https://lore.proxmox.com/all/20250617084448.87536-1-l.wagner@proxmox.com/T/#t
proxmox:
Lukas Wagner (1):
pbs-api-types: change default notification mode to
'notification-system'
pbs-api-types/src/datastore.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
proxmox-backup:
Lukas Wagner (9):
cli: manager: move update-to-prune-jobs command to new migrate-config
sub-command
cli: manager: add 'migrate-config default-notification-mode' command
d/postinst: migrate notification mode default on update
ui: datastore options view: switch to new notification-mode default
ui: tape backup job: move notification settings to a separate tab
ui: one-shot tape backup: use same wording as tape-backup jobs
ui: datastore options: notifications: use same jargon as tape-jobs and
PVE
ui: datastore options: drop notify and notify-user rows
ui: datastore options: notification: use radio controls to select mode
debian/postinst | 9 +-
src/bin/proxmox-backup-manager.rs | 6 +-
.../proxmox_backup_manager/migrate_config.rs | 171 ++++++++++++++++++
src/bin/proxmox_backup_manager/mod.rs | 1 +
src/bin/proxmox_backup_manager/prune.rs | 87 +--------
www/datastore/OptionView.js | 33 +---
www/tape/window/TapeBackup.js | 10 +-
www/tape/window/TapeBackupJob.js | 109 ++++++-----
www/window/NotifyOptions.js | 43 +++--
9 files changed, 292 insertions(+), 177 deletions(-)
create mode 100644 src/bin/proxmox_backup_manager/migrate_config.rs
Summary over all repositories:
10 files changed, 293 insertions(+), 178 deletions(-)
--
Generated by git-murpp 0.8.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-06-23 14:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 14:13 Lukas Wagner [this message]
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: change default notification mode to 'notification-system' Lukas Wagner
2025-07-15 22:47 ` [pbs-devel] applied: " Thomas Lamprecht
2025-07-15 22:47 ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 1/9] cli: manager: move update-to-prune-jobs command to new migrate-config sub-command Lukas Wagner
2025-07-15 23:09 ` Thomas Lamprecht
2025-07-15 23:10 ` Thomas Lamprecht
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 2/9] cli: manager: add 'migrate-config default-notification-mode' command Lukas Wagner
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 3/9] d/postinst: migrate notification mode default on update Lukas Wagner
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 4/9] ui: datastore options view: switch to new notification-mode default Lukas Wagner
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 5/9] ui: tape backup job: move notification settings to a separate tab Lukas Wagner
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 6/9] ui: one-shot tape backup: use same wording as tape-backup jobs Lukas Wagner
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 7/9] ui: datastore options: notifications: use same jargon as tape-jobs and PVE Lukas Wagner
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 8/9] ui: datastore options: drop notify and notify-user rows Lukas Wagner
2025-06-23 14:13 ` [pbs-devel] [PATCH proxmox-backup 9/9] ui: datastore options: notification: use radio controls to select mode Lukas Wagner
2025-07-15 23:13 ` [pbs-devel] [PATCH proxmox{,-backup} 00/10] change of default notification-mode; UX improvements Thomas Lamprecht
2025-07-15 23:13 ` [pve-devel] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623141315.288681-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.