[pve-devel] [PATCH manager 1/2] ui: add dedicated form for PBS change detecton mode selector

[Christian Ebner <c.ebner@proxmox.com>]

Reduce duplicate code by merging common parts of the change detection
mode selector. Allows to control a common selector used by the
advanced options of the backup job and the window for one-shot backup
runs in one place.

No functional changes intended.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-biome to apply

 www/manager6/Makefile                               |  1 +
 www/manager6/form/PbsChangeDetectionModeSelector.js | 10 ++++++++++
 www/manager6/panel/BackupAdvancedOptions.js         |  8 +-------
 www/manager6/window/Backup.js                       |  8 +-------
 4 files changed, 13 insertions(+), 14 deletions(-)
 create mode 100644 www/manager6/form/PbsChangeDetectionModeSelector.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index fdf0e816..255271c5 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -55,6 +55,7 @@ JSSRC= 							\
 	form/NotificationModeSelector.js		\
 	form/NotificationTargetSelector.js		\
 	form/NotificationPolicySelector.js		\
+	form/PbsChangeDetectionModeSelector.js		\
 	form/PCISelector.js				\
 	form/PCIMapSelector.js				\
 	form/PermPathSelector.js			\
diff --git a/www/manager6/form/PbsChangeDetectionModeSelector.js b/www/manager6/form/PbsChangeDetectionModeSelector.js
new file mode 100644
index 00000000..6e55aabd
--- /dev/null
+++ b/www/manager6/form/PbsChangeDetectionModeSelector.js
@@ -0,0 +1,10 @@
+Ext.define('PVE.form.PBSChangeDetectionModeSelector', {
+    extend: 'Proxmox.form.KVComboBox',
+    alias: ['widget.pbsChangeDetectionModeSelector'],
+    deleteEmpty: true,
+    comboItems: [
+        ['__default__', 'Default'],
+        ['data', 'Data'],
+        ['metadata', 'Metadata'],
+    ],
+});
diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index fe8cc3bf..32fe4de5 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -276,16 +276,10 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
         {
             xtype: 'pveTwoColumnContainer',
             startColumn: {
-                xtype: 'proxmoxKVComboBox',
+                xtype: 'pbsChangeDetectionModeSelector',
                 fieldLabel: gettext('PBS change detection mode'),
                 name: 'pbs-change-detection-mode',
-                deleteEmpty: true,
                 value: '__default__',
-                comboItems: [
-                    ['__default__', 'Default'],
-                    ['data', 'Data'],
-                    ['metadata', 'Metadata'],
-                ],
             },
             endFlex: 2,
             endColumn: {
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 00ccce4b..d4542453 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -54,17 +54,11 @@ Ext.define('PVE.window.Backup', {
         });
 
         let pbsChangeDetectionModeSelector = Ext.create({
-            xtype: 'proxmoxKVComboBox',
+            xtype: 'pbsChangeDetectionModeSelector',
             flex: 1,
             disabled: true,
             name: 'pbs-change-detection-mode',
-            deleteEmpty: true,
             value: '__default__',
-            comboItems: [
-                ['__default__', 'Default'],
-                ['data', 'Data'],
-                ['metadata', 'Metadata'],
-            ],
         });
 
         let pbsChangeDetection = Ext.create('Ext.form.FieldContainer', {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel