[pve-devel] [PATCH container 1/1] vzdump: switch default PBS change detection mode to `metadata`

[Christian Ebner <c.ebner@proxmox.com>]

Since commit 58839940 ("vzdump: conditionally set PBS change
detection mode option") it is possible to perform container backups
with Proxmox Backup Server as target using additional `data` and
`metadata` modes provided by the Proxmox Backup client.

While the `metadata` mode was introduced to speed up file level
backups [0], the `legacy` mode was kept as default to not
unexpectedly change the mode for container backups.

Switch the default mode to `metadata` for the upcoming Proxmox
Virtual Environment 9 release. By explicitly setting the mode, this
is independent from the PBS client's default.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=3174

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-perltidy to apply

 src/PVE/VZDump/LXC.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
index c10a4c9..84a6e02 100644
--- a/src/PVE/VZDump/LXC.pm
+++ b/src/PVE/VZDump/LXC.pm
@@ -465,8 +465,10 @@ sub archive {
         push @$param, '--backup-type', 'ct';
         push @$param, '--backup-id', $vmid;
         push @$param, '--backup-time', $task->{backup_time};
-        push @$param, '--change-detection-mode', $opts->{"pbs-change-detection-mode"}
-            if $opts->{"pbs-change-detection-mode"};
+        push @$param, '--change-detection-mode',
+            $opts->{"pbs-change-detection-mode"}
+            ? $opts->{"pbs-change-detection-mode"}
+            : 'metadata';
 
         if (my $entries_max = $opts->{"performance"}->{"pbs-entries-max"}) {
             push $param->@*, '--entries-max', $entries_max;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel