all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager] server: api: acme: fix certificate ordering when no account is set
Date: Tue, 13 May 2025 13:56:43 +0200	[thread overview]
Message-ID: <20250513115643.2170725-1-d.csapak@proxmox.com> (raw)

in case no account is set, the assumption is that we want to use the
'default' account. Since the `AcmeConfig` has no default_key set,
the format `account=default` is required.

was reported in the forum:
https://forum.proxmox.com/threads/166092/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively, we could set the default_key there, but this format is
the same as it lands in the config

 server/src/api/nodes/certificates.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/api/nodes/certificates.rs b/server/src/api/nodes/certificates.rs
index 3d9ac82..52c2ae3 100644
--- a/server/src/api/nodes/certificates.rs
+++ b/server/src/api/nodes/certificates.rs
@@ -270,7 +270,7 @@ fn spawn_certificate_worker(
     let acme_config = if let Some(cfg) = cert_config.acme_config().transpose()? {
         cfg
     } else {
-        proxmox_acme_api::parse_acme_config_string("default")?
+        proxmox_acme_api::parse_acme_config_string("account=default")?
     };
 
     WorkerTask::spawn(name, None, auth_id, true, move |worker| async move {
@@ -317,7 +317,7 @@ pub fn revoke_acme_cert(rpcenv: &mut dyn RpcEnvironment) -> Result<String, Error
     let acme_config = if let Some(cfg) = cert_config.acme_config().transpose()? {
         cfg
     } else {
-        proxmox_acme_api::parse_acme_config_string("default")?
+        proxmox_acme_api::parse_acme_config_string("account=default")?
     };
 
     WorkerTask::spawn(
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


                 reply	other threads:[~2025-05-13 11:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513115643.2170725-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal