* [pve-devel] [PATCH storage] esxi plugin: remove invalid fixme
@ 2025-05-09 11:31 Fiona Ebner
2025-05-12 8:55 ` [pve-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2025-05-09 11:31 UTC (permalink / raw)
To: pve-devel
No other plugin activates the storage inside the path() method either.
The caller needs to ensure that the storage is activated before using
the result of path().
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/Storage/ESXiPlugin.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index 6131c51..bedeac8 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src/PVE/Storage/ESXiPlugin.pm
@@ -477,7 +477,6 @@ sub path {
die "storage '$class' does not support snapshots\n" if defined $snapname;
- # FIXME: activate/mount:
return mount_dir($storeid) . '/' . $volname;
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH storage] esxi plugin: remove invalid fixme
2025-05-09 11:31 [pve-devel] [PATCH storage] esxi plugin: remove invalid fixme Fiona Ebner
@ 2025-05-12 8:55 ` Wolfgang Bumiller
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2025-05-12 8:55 UTC (permalink / raw)
To: Fiona Ebner; +Cc: pve-devel
applied, thanks
On Fri, May 09, 2025 at 01:31:59PM +0200, Fiona Ebner wrote:
> No other plugin activates the storage inside the path() method either.
> The caller needs to ensure that the storage is activated before using
> the result of path().
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/Storage/ESXiPlugin.pm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
> index 6131c51..bedeac8 100644
> --- a/src/PVE/Storage/ESXiPlugin.pm
> +++ b/src/PVE/Storage/ESXiPlugin.pm
> @@ -477,7 +477,6 @@ sub path {
>
> die "storage '$class' does not support snapshots\n" if defined $snapname;
>
> - # FIXME: activate/mount:
> return mount_dir($storeid) . '/' . $volname;
> }
>
> --
> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-12 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-09 11:31 [pve-devel] [PATCH storage] esxi plugin: remove invalid fixme Fiona Ebner
2025-05-12 8:55 ` [pve-devel] applied: " Wolfgang Bumiller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.