all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/2] fix #6358: group removal fails if group notes exist
Date: Wed,  7 May 2025 17:38:32 +0200	[thread overview]
Message-ID: <20250507153834.758840-1-c.ebner@proxmox.com> (raw)

These patches fix an issue with the backup group removal failing and
leaving behind an unusable backup group, due to not taking a possibly
present backup group's notes file into account.

The series consists of 2 patches, the first being preparatory,
allowing to reuse the group notes filepath helper, the second fixing
the actual issue by conditionally removing the notes file before
further group directory cleanup.

Link to the bugtracker issue:
https://bugzilla.proxmox.com/show_bug.cgi?id=6358

Christian Ebner (2):
  api: datastore: make group notes path helper a DataStore method
  fix #6358: remove group note file if present on group destroy

 pbs-datastore/src/backup_info.rs |  7 +++++++
 pbs-datastore/src/datastore.rs   | 11 +++++++++++
 src/api2/admin/datastore.rs      | 26 +++++++-------------------
 3 files changed, 25 insertions(+), 19 deletions(-)

-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-05-07 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 15:38 Christian Ebner [this message]
2025-05-07 15:38 ` [pbs-devel] [PATCH proxmox-backup 1/2] api: datastore: make group notes path helper a DataStore method Christian Ebner
2025-05-07 15:38 ` [pbs-devel] [PATCH proxmox-backup 2/2] fix #6358: remove group note file if present on group destroy Christian Ebner
2025-06-04 11:31 ` [pbs-devel] applied-series: [PATCH proxmox-backup 0/2] fix #6358: group removal fails if group notes exist Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250507153834.758840-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal