From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [yew-devel] [PATCH yew-comp v2 3/4] wizard: optimize enabled check for next button
Date: Wed, 7 May 2025 11:11:11 +0200 [thread overview]
Message-ID: <20250507091112.1145019-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250507091112.1145019-1-d.csapak@proxmox.com>
by first checking for `self.loading` since we don't have to iterate
over the wizard pages if that is true.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* fix typo in commit subject
* use simpler boolean expression instead of if/else
src/wizard.rs | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/wizard.rs b/src/wizard.rs
index e33d3c6..7990cf4 100644
--- a/src/wizard.rs
+++ b/src/wizard.rs
@@ -635,11 +635,7 @@ impl PwtWizard {
Some(key) => props.pages.get_index_of(key).unwrap_or(0),
};
- let mut next_is_enabled = state.can_progress();
-
- if self.loading {
- next_is_enabled = false;
- }
+ let next_is_enabled = !self.loading && state.can_progress();
let next_page = props
.pages
--
2.39.5
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
next prev parent reply other threads:[~2025-05-07 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 9:11 [yew-devel] [PATCH yew-comp v2 1/4] wizard: move page valid/lock data into WizardState Dominik Csapak
2025-05-07 9:11 ` [yew-devel] [PATCH yew-comp v2 2/4] wizard: factor out 'can progress' logic check to WizardState Dominik Csapak
2025-05-07 9:11 ` Dominik Csapak [this message]
2025-05-07 9:11 ` [yew-devel] [PATCH yew-comp v2 4/4] wizard: fix form progressing when pressing enter Dominik Csapak
2025-05-08 9:16 ` [yew-devel] applied: [PATCH yew-comp v2 1/4] wizard: move page valid/lock data into WizardState Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507091112.1145019-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal