[pve-devel] [PATCH manager] fix #4166: restore: add resource pool selector

[pve-devel] [PATCH manager] fix #4166: restore: add resource pool selector

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/window/Restore.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
index 22900868..8d6dfabe 100644
--- a/www/manager6/window/Restore.js
+++ b/www/manager6/window/Restore.js
@@ -47,6 +47,9 @@ Ext.define('PVE.window.Restore', {
 	    if (values.storage) {
 		params.storage = values.storage;
 	    }
+	    if (values.pool) {
+		params.pool = values.pool;
+	    }
 
 	    ['bwlimit', 'cores', 'name', 'memory', 'sockets'].forEach(opt => {
 		if ((values[opt] ?? '') !== '') {
@@ -186,6 +189,13 @@ Ext.define('PVE.window.Restore', {
 		fieldLabel: gettext('Source'),
 	    },
 	    storagesel,
+	    {
+		xtype: 'pvePoolSelector',
+		fieldLabel: gettext('Resource Pool'),
+		name: 'pool',
+		value: '',
+		allowBlank: true,
+	    },
 	    {
 		xtype: 'pmxDisplayEditField',
 		name: 'vmid',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] fix #4166: restore: add resource pool selector

[Fiona Ebner]

Am 30.04.25 um 12:45 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  www/manager6/window/Restore.js | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
> index 22900868..8d6dfabe 100644
> --- a/www/manager6/window/Restore.js
> +++ b/www/manager6/window/Restore.js
> @@ -47,6 +47,9 @@ Ext.define('PVE.window.Restore', {
>  	    if (values.storage) {
>  		params.storage = values.storage;
>  	    }
> +	    if (values.pool) {
> +		params.pool = values.pool;
> +	    }
>  
>  	    ['bwlimit', 'cores', 'name', 'memory', 'sockets'].forEach(opt => {
>  		if ((values[opt] ?? '') !== '') {
> @@ -186,6 +189,13 @@ Ext.define('PVE.window.Restore', {
>  		fieldLabel: gettext('Source'),
>  	    },
>  	    storagesel,
> +	    {
> +		xtype: 'pvePoolSelector',
> +		fieldLabel: gettext('Resource Pool'),
> +		name: 'pool',
> +		value: '',
> +		allowBlank: true,

In case of an in-place restore, the pool option does not have any
effect, so the selector should be hidden. And pre-existing, but the
backend should print a message/warning that the parameter is ignored.

> +	    },
>  	    {
>  		xtype: 'pmxDisplayEditField',
>  		name: 'vmid',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] superseded: [PATCH manager] fix #4166: restore: add resource pool selector

[Maximiliano Sandoval]

Superseded by https://lore.proxmox.com/pve-devel/20250612082318.118153-1-m.sandoval@proxmox.com/T/#u.

Fiona Ebner <f.ebner@proxmox.com> writes:

> Am 30.04.25 um 12:45 schrieb Maximiliano Sandoval:
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>>  www/manager6/window/Restore.js | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>> 
>> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
>> index 22900868..8d6dfabe 100644
>> --- a/www/manager6/window/Restore.js
>> +++ b/www/manager6/window/Restore.js
>> @@ -47,6 +47,9 @@ Ext.define('PVE.window.Restore', {
>>  	    if (values.storage) {
>>  		params.storage = values.storage;
>>  	    }
>> +	    if (values.pool) {
>> +		params.pool = values.pool;
>> +	    }
>>  
>>  	    ['bwlimit', 'cores', 'name', 'memory', 'sockets'].forEach(opt => {
>>  		if ((values[opt] ?? '') !== '') {
>> @@ -186,6 +189,13 @@ Ext.define('PVE.window.Restore', {
>>  		fieldLabel: gettext('Source'),
>>  	    },
>>  	    storagesel,
>> +	    {
>> +		xtype: 'pvePoolSelector',
>> +		fieldLabel: gettext('Resource Pool'),
>> +		name: 'pool',
>> +		value: '',
>> +		allowBlank: true,
>
> In case of an in-place restore, the pool option does not have any
> effect, so the selector should be hidden. And pre-existing, but the
> backend should print a message/warning that the parameter is ignored.
>
>> +	    },
>>  	    {
>>  		xtype: 'pmxDisplayEditField',
>>  		name: 'vmid',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel