[pve-devel] [PATCH pve-common] fix #5034: Updated the schema for the Email attribute to include a dash

[pve-devel] [PATCH pve-common] fix #5034: Updated the schema for the Email attribute to include a dash

[Alexander Abraham]

This patch fixes bug #5034. A user was having the problem of
attempting to login to PVE with an LDAP server that had a different
mail attribute ID configured. The schema of PVE's LDAP attribute ID
validation didn't accept an extra hyphen in the attribute ID. 
This has now been fixed. I was unable to test this with an 
Open LDAP server.

Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
---
 src/PVE/JSONSchema.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 7c63af1..ed1fb68 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -415,7 +415,7 @@ PVE::JSONSchema::register_format('ldap-simple-attr', \&verify_ldap_simple_attr);
 sub verify_ldap_simple_attr {
     my ($attr, $noerr) = @_;
 
-    if ($attr =~ m/^[a-zA-Z0-9]+$/) {
+    if ($attr =~ m/^[a-zA-Z0-9\-]+$/) {
 	return $attr;
     }
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-common] fix #5034: Updated the schema for the Email attribute to include a dash

[Alexander Abraham]

I was unable to test my patch for this bug because editing the configured schema on Turnkey Linux's OpenLDAP proved to be not doable. After coming to this conclusion, I sent the patch to the pve-devel list and asked the user whether it would be possible for them to test my patch on their setup.

The user who reported the bug replied in the bug thread on Bugzilla (https://bugzilla.proxmox.com/show_bug.cgi?id=5034) saying that they have been using the same schema modification as in my patch for over a year now on their PMG setup.  

> Alexander Abraham <a.abraham@proxmox.com> hat am 29.04.2025 17:41 CEST geschrieben:
> 
>  
> This patch fixes bug #5034. A user was having the problem of
> attempting to login to PVE with an LDAP server that had a different
> mail attribute ID configured. The schema of PVE's LDAP attribute ID
> validation didn't accept an extra hyphen in the attribute ID. 
> This has now been fixed. I was unable to test this with an 
> Open LDAP server.
> 
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
>  src/PVE/JSONSchema.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
> index 7c63af1..ed1fb68 100644
> --- a/src/PVE/JSONSchema.pm
> +++ b/src/PVE/JSONSchema.pm
> @@ -415,7 +415,7 @@ PVE::JSONSchema::register_format('ldap-simple-attr', \&verify_ldap_simple_attr);
>  sub verify_ldap_simple_attr {
>      my ($attr, $noerr) = @_;
>  
> -    if ($attr =~ m/^[a-zA-Z0-9]+$/) {
> +    if ($attr =~ m/^[a-zA-Z0-9\-]+$/) {
>  	return $attr;
>      }
>  
> -- 
> 2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel