[pve-devel] [PATCH pve_flutter_frontend v2] navigation: replace deprecated `onPopInvoked` callback

[pve-devel] [PATCH pve_flutter_frontend v2] navigation: replace deprecated `onPopInvoked` callback

[Shan Shaji]

The `onPopInvoked` callback is deprecated as of
Flutter v3.22.0-23.0.pre. This patch replaces it with the
`onPopInvokedWithResult` callback.

This patch also includes the removal of library declaration as it's
a linting issue and not necessary anymore in the newer version of
flutter.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---

changes since v1:
* revert the removal of `async` keyword.
* update commit description with more details. 


 lib/pages/main_layout_slim.dart         | 2 +-
 lib/states/pve_node_overview_state.dart | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart
index 322bcac..e499f8a 100644
--- a/lib/pages/main_layout_slim.dart
+++ b/lib/pages/main_layout_slim.dart
@@ -71,7 +71,7 @@ class _MainLayoutSlimState extends State<MainLayoutSlim> {
       ],
       child: PopScope(
         canPop: false,
-        onPopInvoked: (didPop) async {
+        onPopInvokedWithResult: (didPop, _) async {
           if (didPop || pageSelector.value != 0) {
             if (pageSelector.value != 0) pageSelector.add(0);
             return;
diff --git a/lib/states/pve_node_overview_state.dart b/lib/states/pve_node_overview_state.dart
index 132764c..64353f8 100644
--- a/lib/states/pve_node_overview_state.dart
+++ b/lib/states/pve_node_overview_state.dart
@@ -1,5 +1,3 @@
-library pve_node_overview_state;
-
 import 'package:built_collection/built_collection.dart';
 import 'package:built_value/built_value.dart';
 import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart';
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve_flutter_frontend v2] navigation: replace deprecated `onPopInvoked` callback

[Thomas Lamprecht]

On Tue, 29 Apr 2025 13:10:00 +0200, Shan Shaji wrote:
> The `onPopInvoked` callback is deprecated as of
> Flutter v3.22.0-23.0.pre. This patch replaces it with the
> `onPopInvokedWithResult` callback.
> 
> This patch also includes the removal of library declaration as it's
> a linting issue and not necessary anymore in the newer version of
> flutter.
> 
> [...]

Applied, thanks!

[1/1] navigation: replace deprecated `onPopInvoked` callback
      commit: 0ba752c432e36c64c86eed173120e8810aeb5861


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel