From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2] pveproxy: create log directory when starting
Date: Wed, 16 Apr 2025 11:18:29 +0200 [thread overview]
Message-ID: <20250416091829.124366-1-m.sandoval@proxmox.com> (raw)
We only create this directory while installing or upgrading the package.
If a user deletes /var/log then they will lose access to the web UI
until they either reinstall or upgrade pve-manager.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v1:
- Unconditionally call mkdir+chown if root
- Improve commit message to reflect this can be fixed by a reinstall
bin/pveproxy | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/bin/pveproxy b/bin/pveproxy
index 20e8f2ab2..914a7c838 100755
--- a/bin/pveproxy
+++ b/bin/pveproxy
@@ -21,10 +21,18 @@ $SIG{'__WARN__'} = sub {
my $prepare = sub {
my $rundir="/var/run/pveproxy";
- if (mkdir($rundir, 0700)) { # only works at first start if we are root)
+ my $logdir = '/var/log/pveproxy';
+
+ my $uid = $<;
+ if ($uid == 0) {
my $gid = getgrnam('www-data') || die "getgrnam failed - $!\n";
my $uid = getpwnam('www-data') || die "getpwnam failed - $!\n";
- chown($uid, $gid, $rundir);
+
+ mkdir($rundir, 0700);
+ chown($uid, $gid, $rundir) || warn "chown $rundir failed";
+
+ mkdir($logdir, 0700);
+ chown($uid, $gid, $logdir) || warn "chown $logdir failed";
}
};
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2025-04-16 9:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416091829.124366-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.