From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v4 proxmox-backup 0/2] fix rare race in garbage collection
Date: Wed, 16 Apr 2025 11:17:16 +0200 [thread overview]
Message-ID: <20250416091718.182071-1-c.ebner@proxmox.com> (raw)
Fixes a rare race in phase 1 of garbage collection, as described in
more detail in the commit message of patch 2.
This patches are intended as stop gap for the time being, until a
different approach to guarantee the presence of index files also
after pruning has been explored and implemented, as suggested by
Thomas [0].
Changes since version 3:
- Refactor open_index_reader to allow distinction between missing index
file and ignored archive type blob.
- Iterate snapshots from newest to oldest to further reduce race window
and simplify accounting logic.
[0] https://lore.proxmox.com/pbs-devel/7bac779b-e564-4f24-b58c-a4411c2a59aa@proxmox.com/
Christian Ebner (2):
garbage collection: distinguish variants for failed open index reader
garbage collection: fix rare race in chunk marking phase
pbs-datastore/src/datastore.rs | 141 ++++++++++++++++++++++-----------
1 file changed, 96 insertions(+), 45 deletions(-)
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-04-16 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 9:17 Christian Ebner [this message]
2025-04-16 9:17 ` [pbs-devel] [PATCH v4 proxmox-backup 1/2] garbage collection: distinguish variants for failed open index reader Christian Ebner
2025-04-16 10:00 ` Fabian Grünbichler
2025-04-16 9:17 ` [pbs-devel] [PATCH v4 proxmox-backup 2/2] garbage collection: fix rare race in chunk marking phase Christian Ebner
2025-04-16 10:00 ` Fabian Grünbichler
2025-04-16 10:51 ` [pbs-devel] superseded: [PATCH v4 proxmox-backup 0/2] fix rare race in garbage collection Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416091718.182071-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.