[pbs-devel] [PATCH proxmox-backup] sync: switch reader back to a shared lock

[pbs-devel] [PATCH proxmox-backup] sync: switch reader back to a shared lock

[Shannon Sterz]

the below commit accidentally switched this lock to an exclusive lock
when it should just be a shared one as that is sufficient for a
reader:

e2c1866b: datastore/api/backup: prepare for fix of #3935 by adding
lock helpers

this has already caused failed backups for a user with a sync job that
runs while they are trying to create a new backup.

https://forum.proxmox.com/threads/165038
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---

this also explains the issue we have seen on an internal pbs host.

 src/server/sync.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/server/sync.rs b/src/server/sync.rs
index 528e2054..09814ef0 100644
--- a/src/server/sync.rs
+++ b/src/server/sync.rs
@@ -480,7 +480,7 @@ impl SyncSource for LocalSource {
     ) -> Result<Arc<dyn SyncSourceReader>, Error> {
         let dir = self.store.backup_dir(ns.clone(), dir.clone())?;
         let guard = dir
-            .lock()
+            .lock_shared()
             .with_context(|| format!("while reading snapshot '{dir:?}' for a sync job"))?;
         Ok(Arc::new(LocalSourceReader {
             _dir_lock: Arc::new(Mutex::new(guard)),
--
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] sync: switch reader back to a shared lock

[Fabian Grünbichler]

On April 16, 2025 10:56 am, Shannon Sterz wrote:
> the below commit accidentally switched this lock to an exclusive lock
> when it should just be a shared one as that is sufficient for a
> reader:
> 
> e2c1866b: datastore/api/backup: prepare for fix of #3935 by adding
> lock helpers
> 
> this has already caused failed backups for a user with a sync job that
> runs while they are trying to create a new backup.
> 
> https://forum.proxmox.com/threads/165038
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> 
> this also explains the issue we have seen on an internal pbs host.
> 
>  src/server/sync.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/server/sync.rs b/src/server/sync.rs
> index 528e2054..09814ef0 100644
> --- a/src/server/sync.rs
> +++ b/src/server/sync.rs
> @@ -480,7 +480,7 @@ impl SyncSource for LocalSource {
>      ) -> Result<Arc<dyn SyncSourceReader>, Error> {
>          let dir = self.store.backup_dir(ns.clone(), dir.clone())?;
>          let guard = dir
> -            .lock()
> +            .lock_shared()
>              .with_context(|| format!("while reading snapshot '{dir:?}' for a sync job"))?;
>          Ok(Arc::new(LocalSourceReader {
>              _dir_lock: Arc::new(Mutex::new(guard)),
> --
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel