[pbs-devel] [PATCH proxmox-backup] rest-server: increase max body size

[pbs-devel] [PATCH proxmox-backup] rest-server: increase max body size

[Gabriel Goller]

Increase maximum POST request body size from 64KB to 512KB to match the value
used in pve-http-server. This change addresses potential limitations with the
newly introduced consent-banner feature, which can contain lots of text
that could approach the previous limits.

The patch to pve-http-server:
Link: https://git.proxmox.com/?p=pve-http-server.git;a=commit;h=2650923a42c9ea357dc0e663a69294410190cc7c

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Link: https://lore.proxmox.com/pbs-devel/e0cfec76-5149-4d3d-80be-b96ae633e1ee@proxmox.com/
Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---
 proxmox-rest-server/src/rest.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/proxmox-rest-server/src/rest.rs b/proxmox-rest-server/src/rest.rs
index f5a72052b888..98e8268fcfba 100644
--- a/proxmox-rest-server/src/rest.rs
+++ b/proxmox-rest-server/src/rest.rs
@@ -405,8 +405,7 @@ async fn get_request_parameters<S: 'static + BuildHasher + Send>(
         http_err!(BAD_REQUEST, "Problems reading request body: {}", err)
     })
     .try_fold(Vec::new(), |mut acc, chunk| async move {
-        // FIXME: max request body size?
-        if acc.len() + chunk.len() < 64 * 1024 {
+        if acc.len() + chunk.len() < 512 * 1024 {
             acc.extend_from_slice(&chunk);
             Ok(acc)
         } else {
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] rest-server: increase max body size

[Thomas Lamprecht]

On Tue, 08 Apr 2025 15:26:26 +0200, Gabriel Goller wrote:
> Increase maximum POST request body size from 64KB to 512KB to match the value
> used in pve-http-server. This change addresses potential limitations with the
> newly introduced consent-banner feature, which can contain lots of text
> that could approach the previous limits.
> 
> The patch to pve-http-server:
> Link: https://git.proxmox.com/?p=pve-http-server.git;a=commit;h=2650923a42c9ea357dc0e663a69294410190cc7c
> 
> [...]

Applied, thanks!

[1/1] rest-server: increase max body size
      commit: cf9e6c03a092acf8808ce83dad9249414fe4d588


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel