From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage v6 1/2] api: rename 'isOva' to 'is_ova' to adhere to style guide
Date: Mon, 7 Apr 2025 12:13:05 +0200 [thread overview]
Message-ID: <20250407101310.3196974-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250407101310.3196974-1-d.csapak@proxmox.com>
see https://pve.proxmox.com/wiki/Perl_Style_Guide#Casing
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
new in v6, could be applied even if the rest of the series is not
src/PVE/API2/Storage/Status.pm | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index 28362ca..3332675 100644
--- a/src/PVE/API2/Storage/Status.pm
+++ b/src/PVE/API2/Storage/Status.pm
@@ -455,7 +455,7 @@ __PACKAGE__->register_method ({
my $filename = PVE::Storage::normalize_content_filename($param->{filename});
my $path;
- my $isOva = 0;
+ my $is_ova = 0;
if ($content eq 'iso') {
if ($filename !~ m![^/]+$PVE::Storage::ISO_EXT_RE_0$!) {
@@ -472,7 +472,7 @@ __PACKAGE__->register_method ({
raise_param_exc({ filename => "invalid filename or wrong extension" });
}
- $isOva = 1;
+ $is_ova = 1;
$path = PVE::Storage::get_import_dir($cfg, $storage);
} else {
raise_param_exc({ content => "upload content type '$content' not allowed" });
@@ -541,7 +541,7 @@ __PACKAGE__->register_method ({
PVE::Storage::assert_iso_content($tmpfilename);
}
- if ($isOva) {
+ if ($is_ova) {
assert_ova_contents($tmpfilename);
}
};
@@ -666,7 +666,7 @@ __PACKAGE__->register_method({
my $filename = PVE::Storage::normalize_content_filename($param->{filename});
my $path;
- my $isOva = 0;
+ my $is_ova = 0;
if ($content eq 'iso') {
if ($filename !~ m![^/]+$PVE::Storage::ISO_EXT_RE_0$!) {
@@ -684,7 +684,7 @@ __PACKAGE__->register_method({
}
if ($filename =~ m/\.ova$/) {
- $isOva = 1;
+ $is_ova = 1;
}
$path = PVE::Storage::get_import_dir($cfg, $storage);
@@ -716,7 +716,7 @@ __PACKAGE__->register_method({
PVE::Storage::assert_iso_content($tmp_path);
}
- if ($isOva) {
+ if ($is_ova) {
assert_ova_contents($tmp_path);
}
};
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 10:13 [pve-devel] [PATCH storage/manager v6] allow down/upload & import of images in the web UI Dominik Csapak
2025-04-07 10:13 ` Dominik Csapak [this message]
2025-04-07 10:13 ` [pve-devel] [PATCH storage v6 2/2] import: allow upload of guest images files into import storage Dominik Csapak
2025-04-07 10:13 ` [pve-devel] [PATCH manager v6 1/4] ui: storage content: allow upload of guest images for import type Dominik Csapak
2025-04-07 10:13 ` [pve-devel] [PATCH manager v6 2/4] ui: form: file selector: allow optional filter Dominik Csapak
2025-04-07 10:13 ` [pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow importing a disk from the import storage Dominik Csapak
2025-04-07 22:13 ` Thomas Lamprecht
2025-04-08 7:01 ` Dominik Csapak
2025-04-08 8:40 ` Thomas Lamprecht
2025-04-08 8:53 ` Dominik Csapak
2025-04-07 10:13 ` [pve-devel] [PATCH manager v6 4/4] ui: upload window: show hint about upload storage location Dominik Csapak
2025-04-07 22:52 ` [pve-devel] partially-applied: [PATCH storage/manager v6] allow down/upload & import of images in the web UI Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407101310.3196974-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal