From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer v2] gui: always set visible-child-name on disk dialog
Date: Fri, 4 Apr 2025 10:39:57 +0200 [thread overview]
Message-ID: <20250404083957.107263-1-m.sandoval@proxmox.com> (raw)
We show the size selection stack page whenever a filesystem is selected
in the dropdown.
At the moment when one selects certain raid setups (e.g. btrfs RAID10),
then enters the Advanced Options page and then selects certain non-raid
setups (e.g ext4), the `raiddisk` page will still be visible since the
visible-child (and visible-child-name) property still points to it.
Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v1:
- Improve commit message
- Describe better the reproducer in the commit
proxinstall | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxinstall b/proxinstall
index 9bbd2f9..03235ac 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1357,6 +1357,7 @@ sub create_hdoption_view {
$options_stack->set_visible_child_name("raiddisk");
} else {
$target_hd_label->set_text("Target Harddisk");
+ $options_stack->set_visible_child_name("hdsize");
}
if ($raid) {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-04-04 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 8:39 Maximiliano Sandoval [this message]
2025-04-04 8:59 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404083957.107263-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.