all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] ui: expose GC cache capacity in datastore tuning parameters.
Date: Thu,  3 Apr 2025 14:27:31 +0200	[thread overview]
Message-ID: <20250403122732.369087-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250403122732.369087-1-c.ebner@proxmox.com>

Displays and allows to edit the configured LRU cache capacity via the
datastore tuning parameters.

A step of 512 is used in the number field for convenience when using
the buttons, more fine grained values can be set by typing.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/Utils.js                |  4 ++++
 www/datastore/OptionView.js | 14 ++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/www/Utils.js b/www/Utils.js
index 2746ef0b5..1572f6e56 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -846,6 +846,10 @@ Ext.define('PBS.Utils', {
 	sync = PBS.Utils.tuningOptions['sync-level'][sync ?? '__default__'];
 	options.push(`${gettext('Sync Level')}: ${sync}`);
 
+	let gc_cache_capacity = tuning['gc-cache-capacity'];
+	delete tuning['gc-cache-capacity'];
+	options.push(`${gettext('GC cache capacity')}: ${gc_cache_capacity ?? Proxmox.Utils.defaultText}`);
+
 	for (const [k, v] of Object.entries(tuning)) {
 	    options.push(`${k}: ${v}`);
 	}
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index e1f38af6f..84ef9fc51 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -271,6 +271,20 @@ Ext.define('PBS.Datastore.Options', {
 			    deleteEmpty: true,
 			    value: '__default__',
 			},
+			{
+			    xtype: 'proxmoxintegerfield',
+			    name: 'gc-cache-capacity',
+			    fieldLabel: gettext('GC cache capacity'),
+			    emptyText: Proxmox.Utils.defaultText,
+			    minValue: 0,
+			    maxValue: 8192,
+			    deleteEmpty: true,
+			    step: 512,
+			    autoEl: {
+				tag: 'div',
+				'data-qtip': gettext('GC LRU cache capacity (in multiples of 1024 chunk digests)'),
+			    },
+			},
 		    ],
 		},
 	    },
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-04-03 12:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 12:27 [pbs-devel] [PATCH proxmox] pbs api types: add garbage collection cache capacity tuning option Christian Ebner
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 2/4] garbage collection: set phase1 LRU cache capacity by " Christian Ebner
2025-04-03 12:27 ` Christian Ebner [this message]
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 4/4] docs: add description for gc-cache-capacity tuning parameter Christian Ebner
2025-04-04 11:58   ` Lukas Wagner
2025-04-04 12:13     ` Christian Ebner
2025-04-04 12:20     ` Thomas Lamprecht
2025-04-04 12:28       ` Lukas Wagner
2025-04-04 12:37         ` Christian Ebner
2025-04-04 11:59 ` [pbs-devel] [PATCH proxmox] pbs api types: add garbage collection cache capacity tuning option Lukas Wagner
2025-04-04 13:08 ` [pbs-devel] superseded: " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250403122732.369087-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal