all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v4 1/3] ui: storage content: allow upload of guest images for import type
Date: Wed, 26 Mar 2025 16:26:06 +0100	[thread overview]
Message-ID: <20250326152608.46560-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250326152608.46560-1-d.csapak@proxmox.com>

by allowing 'qcow2', 'vmdk', 'raw' and 'img' files to upload.
Since we expect raw images to have a '.raw' extension, append that for
'.img' files.

partially fixes #2424

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v3:
* also allow vmdk/raw
* rename '.img' files to '.raw'

 www/manager6/window/DownloadUrlToStorage.js | 4 ++++
 www/manager6/window/UploadToStorage.js      | 7 +++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js
index 3ac80ac9..aabc9d3c 100644
--- a/www/manager6/window/DownloadUrlToStorage.js
+++ b/www/manager6/window/DownloadUrlToStorage.js
@@ -89,6 +89,10 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
 			    filename = matches[1];
 			    compression = matches[2].toLowerCase();
 			}
+		    } else if (view.content === 'import') {
+			if (filename.endsWith('.img')) {
+			    filename += '.raw';
+			}
 		    }
 
 		    view.setValues({
diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js
index cdf548a8..0dad6333 100644
--- a/www/manager6/window/UploadToStorage.js
+++ b/www/manager6/window/UploadToStorage.js
@@ -9,7 +9,7 @@ Ext.define('PVE.window.UploadToStorage', {
     title: gettext('Upload'),
 
     acceptedExtensions: {
-	'import': ['.ova'],
+	'import': ['.ova', '.qcow2', '.raw', '.vmdk', '.img'],
 	iso: ['.img', '.iso'],
 	vztmpl: ['.tar.gz', '.tar.xz', '.tar.zst'],
     },
@@ -135,7 +135,10 @@ Ext.define('PVE.window.UploadToStorage', {
 
 	fileChange: function(input) {
 	    const vm = this.getViewModel();
-	    const name = input.value.replace(/^.*(\/|\\)/, '');
+	    let name = input.value.replace(/^.*(\/|\\)/, '');
+	    if (name.endsWith('.img')) {
+		name += '.raw';
+	    }
 	    const fileInput = input.fileInputEl.dom;
 	    vm.set('filename', name);
 	    vm.set('size', (fileInput.files[0] && Proxmox.Utils.format_size(fileInput.files[0].size)) || '-');
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-03-26 15:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 15:26 [pve-devel] [PATCH storage/manager v4] allow down/upload & import of images in the web UI Dominik Csapak
2025-03-26 15:26 ` [pve-devel] [PATCH storage v4 1/1] import: allow upload of guest images files into import storage Dominik Csapak
2025-03-26 15:26 ` Dominik Csapak [this message]
2025-03-26 15:26 ` [pve-devel] [PATCH manager v4 2/3] ui: form: file selector: allow optional filter Dominik Csapak
2025-03-26 15:26 ` [pve-devel] [PATCH manager v4 3/3] ui: qemu hd edit: allow importing a disk from the import storage Dominik Csapak
2025-03-31 14:06 ` [pve-devel] [PATCH storage/manager v4] allow down/upload & import of images in the web UI Filip Schauer
2025-04-01  8:24 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250326152608.46560-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal