all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH novnc 2/2] fix broken 'extra keys' images
Date: Mon, 24 Mar 2025 16:03:37 +0100	[thread overview]
Message-ID: <20250324150337.3221726-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250324150337.3221726-1-d.csapak@proxmox.com>

this is currently broken upstream and it's unclear if this is the
correct fix, so add it seperately until upstream fixes it themselves.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 .../patches/0020-fix-broken-extra-keys.patch  | 32 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 debian/patches/0020-fix-broken-extra-keys.patch

diff --git a/debian/patches/0020-fix-broken-extra-keys.patch b/debian/patches/0020-fix-broken-extra-keys.patch
new file mode 100644
index 0000000..c072210
--- /dev/null
+++ b/debian/patches/0020-fix-broken-extra-keys.patch
@@ -0,0 +1,32 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Dominik Csapak <d.csapak@proxmox.com>
+Date: Mon, 24 Mar 2025 14:25:39 +0100
+Subject: [PATCH] fix broken extra keys
+
+commit:
+14f9ea5: ("Fix settings panel layout on small screens")
+
+changed the selector for the max-width calculation here to include the
+images type, but this was actually not intended.
+
+Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
+---
+ app/styles/base.css | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/app/styles/base.css b/app/styles/base.css
+index 6e9b25d..948074c 100644
+--- a/app/styles/base.css
++++ b/app/styles/base.css
+@@ -478,7 +478,7 @@ html {
+ .noVNC_panel button,
+ .noVNC_panel select,
+ .noVNC_panel textarea,
+-.noVNC_panel input:not([type=checkbox]):not([type=radio]) {
++.noVNC_panel input:not([type=checkbox]):not([type=radio]):not([type=image]) {
+     margin-left: 6px;
+     /* Prevent inputs in panels from being too wide */
+     max-width: calc(100% - 6px - var(--input-xpadding) * 2);
+-- 
+2.39.5
+
diff --git a/debian/patches/series b/debian/patches/series
index 212add7..66ee38e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -17,3 +17,4 @@
 0017-make-error-hideable.patch
 0018-show-start-button-on-not-running-vm-ct.patch
 0019-show-clipboard-button.patch
+0020-fix-broken-extra-keys.patch
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-03-24 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24 15:03 [pve-devel] [PATCH novnc 0/2] upgrade novnc to 1.6.0 Dominik Csapak
2025-03-24 15:03 ` [pve-devel] [PATCH novnc 1/2] upgrade noVNC and patches " Dominik Csapak
2025-03-24 15:03 ` Dominik Csapak [this message]
2025-03-24 17:28 ` [pve-devel] applied: [PATCH novnc 0/2] upgrade novnc " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250324150337.3221726-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal