From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v7 proxmox 1/10] worker task: include anyhow error context in state error message
Date: Thu, 20 Mar 2025 14:17:02 +0100 [thread overview]
Message-ID: <20250320131711.312894-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250320131711.312894-1-c.ebner@proxmox.com>
Currently the anyhow error context of a given error is not included
in the error message, as `to_string` does use the default formatting
[0].
Include the error context, formatting it as single line as the
message is also shown to the users in e.g. the Proxmox Backup Severs
task state in the UI.
[0] https://docs.rs/anyhow/latest/anyhow/struct.Error.html#display-representations
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 6:
- not present in previous version
proxmox-rest-server/src/worker_task.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs
index 2968a68c..a3a65add 100644
--- a/proxmox-rest-server/src/worker_task.rs
+++ b/proxmox-rest-server/src/worker_task.rs
@@ -1003,7 +1003,7 @@ impl WorkerTask {
if let Err(err) = result {
TaskState::Error {
- message: err.to_string(),
+ message: format!("{err:#}"),
endtime,
}
} else if warn_count > 0 {
--
2.39.5
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-03-20 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 13:17 [pbs-devel] [PATCH v7 proxmox proxmox-backup 00/10] fix #5982: check atime update is honored Christian Ebner
2025-03-20 13:17 ` Christian Ebner [this message]
2025-03-20 13:46 ` [pbs-devel] applied: [PATCH v7 proxmox 1/10] worker task: include anyhow error context in state error message Wolfgang Bumiller
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox 2/10] pbs api types: add garbage collection atime safety check flag Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox 3/3] pbs api types: add option to set GC chunk cleanup atime cutoff Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 04/10] garbage collection: format error including anyhow error context Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 05/10] fix #5982: garbage collection: check atime updates are honored Christian Ebner
2025-03-20 14:59 ` Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 06/10] ui: expose GC atime safety check flag in datastore tuning options Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 07/10] docs: mention GC atime update check for " Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 08/10] datastore: use custom GC atime cutoff if set Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 09/10] ui: expose GC atime cutoff in datastore tuning option Christian Ebner
2025-03-20 13:17 ` [pbs-devel] [PATCH v7 proxmox-backup 10/10] docs: mention gc-atime-cutoff as " Christian Ebner
2025-03-21 8:04 ` [pbs-devel] [PATCH v7 proxmox proxmox-backup 00/10] fix #5982: check atime update is honored Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320131711.312894-2-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal