From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v2 1/1] ui: remote tasks: add loading animation for running tasks
Date: Thu, 20 Mar 2025 10:34:13 +0100 [thread overview]
Message-ID: <20250320093413.804620-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250320093413.804620-1-d.csapak@proxmox.com>
when there is no endtime and the status is either empty or "RUNNING"
(for PVE), render a spinning loading icon, like we do in the ExtJS UI.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* use justifycontent instead of 2 flex spacers
* move match one level up
ui/src/remotes/tasks.rs | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/ui/src/remotes/tasks.rs b/ui/src/remotes/tasks.rs
index 99bb243..afd752e 100644
--- a/ui/src/remotes/tasks.rs
+++ b/ui/src/remotes/tasks.rs
@@ -15,12 +15,12 @@ use proxmox_yew_comp::{
TaskViewer, Tasks,
};
use pwt::{
- css::FlexFit,
+ css::{FlexFit, JustifyContent},
props::{ContainerBuilder, WidgetBuilder},
tr,
widget::{
data_table::{DataTableColumn, DataTableHeader},
- Column,
+ Column, Fa, Row,
},
};
@@ -47,7 +47,10 @@ fn columns() -> Rc<Vec<DataTableHeader<TaskListItem>>> {
.width("130px")
.render(|item: &TaskListItem| match item.endtime {
Some(endtime) => render_epoch_short(endtime).into(),
- None => html! {},
+ None => Row::new()
+ .class(JustifyContent::Center)
+ .with_child(Fa::new("").class("pwt-loading-icon"))
+ .into(),
})
.into(),
DataTableColumn::new(tr!("User name"))
@@ -89,9 +92,12 @@ fn columns() -> Rc<Vec<DataTableHeader<TaskListItem>>> {
.into(),
DataTableColumn::new(tr!("Status"))
.width("minmax(200px, 1fr)")
- .render(|item: &TaskListItem| {
- let text = item.status.as_deref().unwrap_or("");
- html! {text}
+ .render(|item: &TaskListItem| match item.status.as_deref() {
+ Some("" | "RUNNING") | None => Row::new()
+ .class(JustifyContent::Center)
+ .with_child(Fa::new("").class("pwt-loading-icon"))
+ .into(),
+ Some(text) => html! {text},
})
.into(),
])
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-03-20 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 9:34 [pdm-devel] [PATCH yew-comp/datacenter-manager v2] improve rendering " Dominik Csapak
2025-03-20 9:34 ` [pdm-devel] [PATCH yew-comp v2 1/1] tasks: add loading animation for " Dominik Csapak
2025-03-20 11:03 ` Dietmar Maurer
2025-03-20 9:34 ` Dominik Csapak [this message]
2025-03-20 11:18 ` [pdm-devel] [PATCH datacenter-manager v2 1/1] ui: remote " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320093413.804620-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal