From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-firewall v2 2/4] partially fix #6176: ipfilter: honor firewall setting from guest cfg
Date: Thu, 13 Mar 2025 14:22:29 +0100 [thread overview]
Message-ID: <20250313132231.166477-3-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250313132231.166477-1-s.hanreich@proxmox.com>
ipfilter ipsets and rules were still generated, even if the firewall
was disabled for the network device.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
proxmox-firewall/src/firewall.rs | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/proxmox-firewall/src/firewall.rs b/proxmox-firewall/src/firewall.rs
index e980bd5..0e0edf8 100644
--- a/proxmox-firewall/src/firewall.rs
+++ b/proxmox-firewall/src/firewall.rs
@@ -781,6 +781,10 @@ impl Firewall {
let network_devices = cfg.network_config().network_devices();
for (index, network_device) in network_devices {
+ if !network_device.has_firewall() {
+ continue;
+ }
+
let ipfilter_name = Ipfilter::name_for_index(*index);
if let Some(ipset) = ipsets.get(&ipfilter_name) {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-13 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 13:22 [pve-devel] [PATCH proxmox-ve-rs v2 1/1] partially fix #6176: config: guest: change default for firewall key Stefan Hanreich
2025-03-13 13:22 ` [pve-devel] [PATCH proxmox-firewall v2 1/4] ipsets: remove dereference Stefan Hanreich
2025-04-07 11:51 ` [pve-devel] applied-series: " Thomas Lamprecht
2025-03-13 13:22 ` Stefan Hanreich [this message]
2025-03-13 13:22 ` [pve-devel] [PATCH proxmox-firewall v2 3/4] partially fix #6176: do not generate mac filter if firewall disabled Stefan Hanreich
2025-03-13 13:22 ` [pve-devel] [PATCH proxmox-firewall v2 4/4] tests: add network device without firewall key Stefan Hanreich
2025-03-13 16:22 ` [pve-devel] [PATCH proxmox-ve-rs v2 1/1] partially fix #6176: config: guest: change default for " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313132231.166477-3-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal