all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-firewall v2 1/4] ipsets: remove dereference
Date: Thu, 13 Mar 2025 14:22:28 +0100	[thread overview]
Message-ID: <20250313132231.166477-2-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250313132231.166477-1-s.hanreich@proxmox.com>

The network device configuration doesn't return a reference anymore,
so we do not need to dereference here anymore.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---

Notes:
    This and the subsequent tests patch require a bump of proxmox-ve-config to work

 proxmox-firewall/src/firewall.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-firewall/src/firewall.rs b/proxmox-firewall/src/firewall.rs
index 88fb460..e980bd5 100644
--- a/proxmox-firewall/src/firewall.rs
+++ b/proxmox-firewall/src/firewall.rs
@@ -801,11 +801,11 @@ impl Firewall {
                     ipset.push(cidr.into());
 
                     if let Some(ip_address) = network_device.ip() {
-                        ipset.push(IpsetEntry::from(*ip_address));
+                        ipset.push(IpsetEntry::from(ip_address));
                     }
 
                     if let Some(ip6_address) = network_device.ip6() {
-                        ipset.push(IpsetEntry::from(*ip6_address));
+                        ipset.push(IpsetEntry::from(ip6_address));
                     }
 
                     commands.append(&mut ipset.to_nft_objects(&env)?);
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-03-13 13:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 13:22 [pve-devel] [PATCH proxmox-ve-rs v2 1/1] partially fix #6176: config: guest: change default for firewall key Stefan Hanreich
2025-03-13 13:22 ` Stefan Hanreich [this message]
2025-04-07 11:51   ` [pve-devel] applied-series: [PATCH proxmox-firewall v2 1/4] ipsets: remove dereference Thomas Lamprecht
2025-03-13 13:22 ` [pve-devel] [PATCH proxmox-firewall v2 2/4] partially fix #6176: ipfilter: honor firewall setting from guest cfg Stefan Hanreich
2025-03-13 13:22 ` [pve-devel] [PATCH proxmox-firewall v2 3/4] partially fix #6176: do not generate mac filter if firewall disabled Stefan Hanreich
2025-03-13 13:22 ` [pve-devel] [PATCH proxmox-firewall v2 4/4] tests: add network device without firewall key Stefan Hanreich
2025-03-13 16:22 ` [pve-devel] [PATCH proxmox-ve-rs v2 1/1] partially fix #6176: config: guest: change default for " Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250313132231.166477-2-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal