From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH network 0/3] smaller fixes and clean-ups
Date: Thu, 6 Mar 2025 10:18:15 +0100 [thread overview]
Message-ID: <20250306091818.3841361-1-t.lamprecht@proxmox.com> (raw)
To bugs got noticed by Fiona, namely missing use statements – which was
not relevant in practice, but still good to have them correct as it
easily can cause "spooky actions at a distance" when changing things
elsewhere. The other one was a conditional use-statement, which is
always a rather nasty bug that caused that the previously encoded data
from the last call to this method was kept if no new one was passed.
The third one is a clean-up of duplicated code in the PowerDNS
integration plugin.
All three patches already applied to git master branch.
Thomas Lamprecht (3):
fix missing use statements in core SDN module
api request helper: fix conditional declaration
ipam dns: powerdns integration: factor out common API request code
src/PVE/Network/SDN.pm | 14 +++--
src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 77 ++++++-----------------
2 files changed, 28 insertions(+), 63 deletions(-)
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-03-06 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 9:18 Thomas Lamprecht [this message]
2025-03-06 9:18 ` [pve-devel] [PATCH network 1/3] fix missing use statements in core SDN module Thomas Lamprecht
2025-03-06 9:18 ` [pve-devel] [PATCH network 2/3] api request helper: fix conditional declaration Thomas Lamprecht
2025-03-06 9:18 ` [pve-devel] [PATCH network 3/3] ipam dns: powerdns integration: factor out common API request code Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306091818.3841361-1-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.