all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template
@ 2025-03-04 10:44 Stoiko Ivanov
  2025-03-04 10:44 ` [pve-devel] [PATCH dab-pve-appliances 1/2] pmg: reformat dab install invocation and sort entries Stoiko Ivanov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2025-03-04 10:44 UTC (permalink / raw)
  To: pve-devel

the request seems sensible, and dbus is usually present on current debian
systems.

the regular debian-template is not affected, because it installs all
packages with priority standard (dbus has priority standard)

minimally tested the result locally.

Stoiko Ivanov (2):
  pmg: reformat dab install invocation and sort entries
  fix #5700: pmg: add dbus to installed packages

 debian-12-bookworm-pmg-8-64/Makefile | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH dab-pve-appliances 1/2] pmg: reformat dab install invocation and sort entries
  2025-03-04 10:44 [pve-devel] [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template Stoiko Ivanov
@ 2025-03-04 10:44 ` Stoiko Ivanov
  2025-03-04 10:44 ` [pve-devel] [PATCH dab-pve-appliances 2/2] fix #5700: pmg: add dbus to installed packages Stoiko Ivanov
  2025-03-04 11:04 ` [pve-devel] applied: [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2025-03-04 10:44 UTC (permalink / raw)
  To: pve-devel

no semantic change intended.

adding new packages causes a bit of churn in the diff otherwise

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 debian-12-bookworm-pmg-8-64/Makefile | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/debian-12-bookworm-pmg-8-64/Makefile b/debian-12-bookworm-pmg-8-64/Makefile
index ab590bc..55e6424 100644
--- a/debian-12-bookworm-pmg-8-64/Makefile
+++ b/debian-12-bookworm-pmg-8-64/Makefile
@@ -8,8 +8,20 @@ all: info/init_ok ${CVD_FILES}
 	mkdir -p ${BASEDIR}/etc/systemd/system-preset
 	cp systemd-presets ${BASEDIR}/etc/systemd/system-preset/00-pve-template.preset
 	touch ${BASEDIR}/proxmox_install_mode
-	dab install libdbi-perl perl-openssl-defaults libcgi-pm-perl proxmox-mailgateway-container gpg ifupdown2
-	dab install antiword docx2txt odt2txt poppler-utils tesseract-ocr unrtf libsasl2-modules
+	dab install \
+	    antiword \
+	    docx2txt \
+	    gpg \
+	    ifupdown2 \
+	    libcgi-pm-perl \
+	    libdbi-perl \
+	    libsasl2-modules \
+	    odt2txt \
+	    perl-openssl-defaults \
+	    poppler-utils \
+	    proxmox-mailgateway-container \
+	    tesseract-ocr \
+	    unrtf
 	rm ${BASEDIR}/proxmox_install_mode
 	sed -i '/^deb.*\.proxmox\.com\/.*$$/d;$${/^$$/d;}' ${BASEDIR}/etc/apt/sources.list
 	cp ${CVD_FILES} ${BASEDIR}/var/lib/clamav/
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH dab-pve-appliances 2/2] fix #5700: pmg: add dbus to installed packages
  2025-03-04 10:44 [pve-devel] [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template Stoiko Ivanov
  2025-03-04 10:44 ` [pve-devel] [PATCH dab-pve-appliances 1/2] pmg: reformat dab install invocation and sort entries Stoiko Ivanov
@ 2025-03-04 10:44 ` Stoiko Ivanov
  2025-03-04 11:04 ` [pve-devel] applied: [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2025-03-04 10:44 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 debian-12-bookworm-pmg-8-64/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian-12-bookworm-pmg-8-64/Makefile b/debian-12-bookworm-pmg-8-64/Makefile
index 55e6424..0f4a70a 100644
--- a/debian-12-bookworm-pmg-8-64/Makefile
+++ b/debian-12-bookworm-pmg-8-64/Makefile
@@ -10,6 +10,7 @@ all: info/init_ok ${CVD_FILES}
 	touch ${BASEDIR}/proxmox_install_mode
 	dab install \
 	    antiword \
+	    default-dbus-system-bus \
 	    docx2txt \
 	    gpg \
 	    ifupdown2 \
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied: [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template
  2025-03-04 10:44 [pve-devel] [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template Stoiko Ivanov
  2025-03-04 10:44 ` [pve-devel] [PATCH dab-pve-appliances 1/2] pmg: reformat dab install invocation and sort entries Stoiko Ivanov
  2025-03-04 10:44 ` [pve-devel] [PATCH dab-pve-appliances 2/2] fix #5700: pmg: add dbus to installed packages Stoiko Ivanov
@ 2025-03-04 11:04 ` Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-03-04 11:04 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stoiko Ivanov

Am 04.03.25 um 11:44 schrieb Stoiko Ivanov:
> the request seems sensible, and dbus is usually present on current debian
> systems.
> 
> the regular debian-template is not affected, because it installs all
> packages with priority standard (dbus has priority standard)
> 
> minimally tested the result locally.
> 
> Stoiko Ivanov (2):
>   pmg: reformat dab install invocation and sort entries
>   fix #5700: pmg: add dbus to installed packages
> 
>  debian-12-bookworm-pmg-8-64/Makefile | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 


applied both patches, thanks!

I amended the first one to end the last package entry also with a trailing
backslash to avoid churn when adding any package that would sort at the end.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-04 11:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-04 10:44 [pve-devel] [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template Stoiko Ivanov
2025-03-04 10:44 ` [pve-devel] [PATCH dab-pve-appliances 1/2] pmg: reformat dab install invocation and sort entries Stoiko Ivanov
2025-03-04 10:44 ` [pve-devel] [PATCH dab-pve-appliances 2/2] fix #5700: pmg: add dbus to installed packages Stoiko Ivanov
2025-03-04 11:04 ` [pve-devel] applied: [PATCH dab-pve-appliances 0/2] fix #5700 - add dbus to pmg appliance template Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal