all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui] system options: html encode 'from for admin mail' field
Date: Wed, 26 Feb 2025 10:50:07 +0100	[thread overview]
Message-ID: <20250226095007.954688-1-d.csapak@proxmox.com> (raw)

since that often has the format of: "Name <some@email.example>"
and the <..> part will be incorrectly interpreted as html otherwise.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/SystemOptions.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/SystemOptions.js b/js/SystemOptions.js
index 3c8d960..cc098ce 100644
--- a/js/SystemOptions.js
+++ b/js/SystemOptions.js
@@ -76,7 +76,7 @@ Ext.define('PMG.SystemOptions', {
 			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText });
 
 	me.add_text_row('admin-mail-from', gettext("'From:' for Admin Mail"),
-			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText });
+			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText, renderer: Ext.htmlEncode });
 
 	me.add_proxy_row('http_proxy', gettext("HTTP proxy"));
 
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


             reply	other threads:[~2025-02-26  9:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  9:50 Dominik Csapak [this message]
2025-02-26  9:58 ` [pmg-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250226095007.954688-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal