[pbs-devel] [PATCH backup v2] pull_metrics: rename argument called gen to generation

[pbs-devel] [PATCH backup v2] pull_metrics: rename argument called gen to generation

[Maximiliano Sandoval]

gen is a reserved keyword in the rust 2024 edition. See
https://doc.rust-lang.org/edition-guide/rust-2024/gen-keyword.html.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/server/metric_collection/pull_metrics.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/server/metric_collection/pull_metrics.rs b/src/server/metric_collection/pull_metrics.rs
index 1b5f3777..3b105eaf 100644
--- a/src/server/metric_collection/pull_metrics.rs
+++ b/src/server/metric_collection/pull_metrics.rs
@@ -73,9 +73,9 @@ pub fn get_all_metrics(start_time: i64) -> Result<Vec<MetricDataPoint>, Error> {
 
     let mut points = Vec::new();
 
-    for gen in cached_datapoints {
-        if gen.timestamp > start_time {
-            points.extend(gen.datapoints);
+    for generation in cached_datapoints {
+        if generation.timestamp > start_time {
+            points.extend(generation.datapoints);
         }
     }
 
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH backup v2] pull_metrics: rename argument called gen to generation

[Fabian Grünbichler]

thanks!

On February 21, 2025 1:53 pm, Maximiliano Sandoval wrote:
> gen is a reserved keyword in the rust 2024 edition. See
> https://doc.rust-lang.org/edition-guide/rust-2024/gen-keyword.html.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/server/metric_collection/pull_metrics.rs | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/server/metric_collection/pull_metrics.rs b/src/server/metric_collection/pull_metrics.rs
> index 1b5f3777..3b105eaf 100644
> --- a/src/server/metric_collection/pull_metrics.rs
> +++ b/src/server/metric_collection/pull_metrics.rs
> @@ -73,9 +73,9 @@ pub fn get_all_metrics(start_time: i64) -> Result<Vec<MetricDataPoint>, Error> {
>  
>      let mut points = Vec::new();
>  
> -    for gen in cached_datapoints {
> -        if gen.timestamp > start_time {
> -            points.extend(gen.datapoints);
> +    for generation in cached_datapoints {
> +        if generation.timestamp > start_time {
> +            points.extend(generation.datapoints);
>          }
>      }
>  
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel