From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH 3/3] pmxcfg: use g_string_append_c when appropiate
Date: Thu, 20 Feb 2025 13:48:04 +0100 [thread overview]
Message-ID: <20250220124804.263191-3-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250220124804.263191-1-m.sandoval@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/pmxcfs/logger.c | 2 +-
src/pmxcfs/status.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/pmxcfs/logger.c b/src/pmxcfs/logger.c
index 0be4be6..d6e281f 100644
--- a/src/pmxcfs/logger.c
+++ b/src/pmxcfs/logger.c
@@ -201,7 +201,7 @@ clog_dump_json(
}
if (count)
- g_string_append(str, "\n");
+ g_string_append_c(str, '\n');
g_string_append(str, "]\n");
g_string_append(str, "}\n");
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index 7533057..ac94ac7 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -1418,9 +1418,9 @@ cfs_rrd_dump(GString *str)
while (g_hash_table_iter_next (&iter, &key, &value)) {
rrdentry_t *entry = (rrdentry_t *)value;
g_string_append(str, key);
- g_string_append(str, ":");
+ g_string_append_c(str, ':');
g_string_append(str, entry->data);
- g_string_append(str, "\n");
+ g_string_append_c(str, '\n');
}
g_string_append_c(str, 0); // never return undef
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-02-20 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 12:48 [pve-devel] [PATCH 1/3] pmxcfs: Use g_string_append when appropriate Maximiliano Sandoval
2025-02-20 12:48 ` [pve-devel] [PATCH 2/3] pmxcfs: use g_string_assign when appropiate Maximiliano Sandoval
2025-02-20 12:48 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220124804.263191-3-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.