all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage v4 7/7] btrfs: rename snapshot parameter
Date: Wed, 19 Feb 2025 12:17:40 +0100	[thread overview]
Message-ID: <20250219111740.200819-7-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20250219111740.200819-1-m.sandoval@proxmox.com>

It was originally introduced as $snapshot to match the argument name of
foreach_subvol, we rename it here to make it clear that it only contains
the snapshot name.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/Storage/BTRFSPlugin.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm
index c82d5f7..a28996c 100644
--- a/src/PVE/Storage/BTRFSPlugin.pm
+++ b/src/PVE/Storage/BTRFSPlugin.pm
@@ -407,18 +407,18 @@ my sub path_is_subvolume : prototype($) {
 
 my $BTRFS_SNAPSHOT_REGEX = qr/((?:vm|base|subvol)-\d+-disk-\d+(?:\.subvol)?)(?:\@(\S+))$/;
 
-# Calls `$code->($snapshot)` for each snapshot of the BTRFS subvolume.
+# Calls `$code->($snap_name)` for each snapshot of the BTRFS subvolume.
 my sub foreach_snapshot_of_subvol : prototype($$) {
     my ($subvol, $code) = @_;
 
     my $basename = basename($subvol);
     my $dir = dirname($subvol);
     dir_glob_foreach($dir, $BTRFS_SNAPSHOT_REGEX, sub {
-	my ($volume, $name, $snapshot) = ($1, $2, $3);
+	my ($volume, $name, $snap_name) = ($1, $2, $3);
 	return if !path_is_subvolume("$dir/$volume");
 	return if $name ne $basename;
-	return if !defined $snapshot;
-	$code->($snapshot);
+	return if !defined $snap_name;
+	$code->($snap_name);
     });
 }
 
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-02-19 11:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19 11:17 [pve-devel] [PATCH storage v4 1/7] btrfs: add helper to iterate over snapshots of a subvolume Maximiliano Sandoval
2025-02-19 11:17 ` [pve-devel] [PATCH storage v4 2/7] fix #3873: btrfs: use foreach_snapshot_of_subvol helper in volume_export Maximiliano Sandoval
2025-02-19 11:17 ` [pve-devel] [PATCH storage v4 3/7] btrfs: use foreach_snapshot_of_subvol helper in free_image Maximiliano Sandoval
2025-02-19 11:17 ` [pve-devel] [PATCH storage v4 4/7] btrfs: forcefully set image to readwrite Maximiliano Sandoval
2025-02-21 15:44   ` Fiona Ebner
2025-02-24  8:43     ` Maximiliano Sandoval
2025-02-19 11:17 ` [pve-devel] [PATCH storage v4 5/7] btrfs: rename volume regex Maximiliano Sandoval
2025-02-19 11:17 ` [pve-devel] [PATCH storage v4 6/7] btrfs: remove foreach_subvol Maximiliano Sandoval
2025-02-19 11:17 ` Maximiliano Sandoval [this message]
2025-02-24  9:21 ` [pve-devel] applied-series: [PATCH storage v4 1/7] btrfs: add helper to iterate over snapshots of a subvolume Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250219111740.200819-7-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal