Re: [pmg-devel] [PATCH pmg-gui 1/2] rules/object: remove icon from remove button

[Stoiko Ivanov <s.ivanov@proxmox.com>]

On Wed, 12 Feb 2025 16:12:40 +0100
Stoiko Ivanov <s.ivanov@proxmox.com> wrote:

> the icons were introduced to the listing, and it seems their rendering
> when removing was not noticed - w/o this the message is e.g.:
> "Are you sure you want to remove entry
> '<span class="fa-fw fa fa-file-image-o'"></span> Content Type Filter:
> ..."
> 
> Fixes: ea4f2a7 ("add icons to the object types")
after talking with Dominik off-list went and checked again:
the issue surfaced due to a (much more recent) commit in
proxmox-widet-toolkit:
7bb124c ("button: htmlEncode the name/id for the confirm message")

I think we can drop the icon for the remove-message, but if someone feels
that it makes for a worse UX I can see if this can be sensibly added back.


> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  js/ObjectGroup.js | 3 +--
>  js/Utils.js       | 5 +++++
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/js/ObjectGroup.js b/js/ObjectGroup.js
> index 3c8de64..1807e97 100644
> --- a/js/ObjectGroup.js
> +++ b/js/ObjectGroup.js
> @@ -125,8 +125,7 @@ Ext.define('PMG.ObjectGroup', {
>  	    },
>  	    callback: reload,
>  	    getRecordName: function(rec) {
> -		return PMG.Utils.format_otype(rec.data.otype) +
> -		    ': ' + rec.data.descr;
> +		return PMG.Utils.format_otype_subject(rec.data.otype) + ': ' + rec.data.descr;
>  	    },
>  	    waitMsgTarget: me,
>  	});
> diff --git a/js/Utils.js b/js/Utils.js
> index 9b5f054..94e3c95 100644
> --- a/js/Utils.js
> +++ b/js/Utils.js
> @@ -128,6 +128,11 @@ Ext.define('PMG.Utils', {
>  	return icon + text;
>      },
>  
> +    format_otype_subject: function(otype) {
> +	let editor = PMG.Utils.object_editors[otype];
> +	return editor.subject ?? 'unknown';
> +    },
> +
>      format_otype: function(otype) {
>  	let editor = PMG.Utils.object_editors[otype];
>  	let iconCls = 'fa fa-question-circle';



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel