all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api/pmg-gui] add information source attribute to content-type what-object
Date: Wed, 12 Feb 2025 16:12:37 +0100	[thread overview]
Message-ID: <20250212151241.91077-1-s.ivanov@proxmox.com> (raw)

The following patch series was started shortly after the release of PMG 8.1,
but I did not find the time to get it in shape for sending.
They follow the patches for adding 'top' and 'add_separator' to the
Disclaimer action.

The current content-type filter can sometimes surprise users (e.g.
https://bugzilla.proxmox.com/show_bug.cgi?id=5618#c2 and
https://bugzilla.proxmox.com/show_bug.cgi?id=2691#c0 ,but also a few
cases in our technical support-channels come up here and there):

It matches if any of:
* content-type header
* file-magic
* filename (extension)
match the content type, the what-object matches.
by adding an attribute for each of the sources users can restrict which
of the sources should be taken into consideration

the first patches for both repositories are independent (I just ran into
them while looking into this).

minimally tested locally, by sending a plain-text file called
testtext.pdf, and a pdf-file renamed to have a `.docx` suffix.

pmg-api:
Stoiko Ivanov (2):
  ruledb: disclaimer: simplify update-case
  ruledb: content-type: add flags for source of matching

 src/PMG/RuleDB/ContentTypeFilter.pm | 91 +++++++++++++++++++++++++++--
 src/PMG/RuleDB/Disclaimer.pm        |  8 +--
 2 files changed, 89 insertions(+), 10 deletions(-)

pmg-gui:
Stoiko Ivanov (2):
  rules/object: remove icon from remove button
  rules/content-typefilter: add match source checkboxes

 js/ObjectGroup.js |  3 +--
 js/Utils.js       | 26 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 2 deletions(-)

-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


             reply	other threads:[~2025-02-12 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 15:12 Stoiko Ivanov [this message]
2025-02-12 15:12 ` [pmg-devel] [PATCH pmg-api 1/2] ruledb: disclaimer: simplify update-case Stoiko Ivanov
2025-02-12 15:12 ` [pmg-devel] [PATCH pmg-api 2/2] ruledb: content-type: add flags for source of matching Stoiko Ivanov
2025-02-17 13:03   ` Dominik Csapak
2025-02-17 14:44     ` Stoiko Ivanov
2025-02-12 15:12 ` [pmg-devel] [PATCH pmg-gui 1/2] rules/object: remove icon from remove button Stoiko Ivanov
2025-02-13 10:37   ` Stoiko Ivanov
2025-02-12 15:12 ` [pmg-devel] [PATCH pmg-gui 2/2] rules/content-typefilter: add match source checkboxes Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212151241.91077-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal