[pve-devel] [PATCH manager] fix #6116: ui: qemu: create wizard: order install ISO before additional ISO in boot order

[pve-devel] [PATCH manager] fix #6116: ui: qemu: create wizard: order install ISO before additional ISO in boot order

[Fiona Ebner]

Also clarify the function comment with the original intention for why
this was added in the frontend (the backend cannot know which is
which), see commit fc3a88ad ("ui: qemu wizard: use better boot order
for second cd drive").

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/qemu/CreateWizard.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index 520b5ac2..96949fe9 100644
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -28,9 +28,8 @@ Ext.define('PVE.qemu.CreateWizard', {
 
     // fot the special case that we have 2 cdrom drives
     //
-    // emulates part of the backend bootorder logic, but includes all
-    // cdrom drives since we don't know which one the user put in a bootable iso
-    // and hardcodes the known values (ide0/2, net0)
+    // emulates part of the backend bootorder logic, but includes all cdrom drives since the backend
+    // cannot know which one is a bootable iso and hardcodes the known values (ide0/2, net0)
     calculateBootOrder: function(values) {
 	// user selected windows + second cdrom
 	if (values.ide0 && values.ide0.match(/media=cdrom/)) {
@@ -51,7 +50,7 @@ Ext.define('PVE.qemu.CreateWizard', {
 	    if (disk) {
 		order.push(disk);
 	    }
-	    order.push('ide0', 'ide2');
+	    order.push('ide2', 'ide0'); // ide2 is the install ISO and should be first
 	    if (values.net0) {
 		order.push('net0');
 	    }
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] fix #6116: ui: qemu: create wizard: order install ISO before additional ISO in boot order

[Thomas Lamprecht]

On Thu, 30 Jan 2025 10:49:56 +0100, Fiona Ebner wrote:
> Also clarify the function comment with the original intention for why
> this was added in the frontend (the backend cannot know which is
> which), see commit fc3a88ad ("ui: qemu wizard: use better boot order
> for second cd drive").

Applied, thanks!

[1/1] fix #6116: ui: qemu: create wizard: order install ISO before additional ISO in boot order
      commit: 0326691c2f90f8ad9b80f36f419f697f24091c76


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel