[yew-devel] [PATCH yew-widget-toolkit 2/2] state: selection: make selection interface more consistent

[Dominik Csapak <d.csapak@proxmox.com>]

due to the interior mutability of th Selection (it uses Rc<RefCell<>>),
we don't need the selection to be mutable when we select something. This
is reflected in in the interface for e.g. `select()` and `toggle()`
which only take a `&self`. For `bulk_select()` the same logic can be
applied, but it still took a `&mut self` which was not a problem, but it
was unnecessary. To make it more consistent, simply change from `&mut
self` to `&self`.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/state/selection.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/state/selection.rs b/src/state/selection.rs
index 21e8e85..6866436 100644
--- a/src/state/selection.rs
+++ b/src/state/selection.rs
@@ -151,7 +151,7 @@ impl Selection {
     /// # Panics
     ///
     /// If multiselect is false.
-    pub fn bulk_select(&mut self, map: HashSet<Key>) {
+    pub fn bulk_select(&self, map: HashSet<Key>) {
         self.inner.borrow_mut().bulk_select(map);
         self.notify_listeners();
     }
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel