[pbs-devel] [PATCH proxmox] proxmox-router: Improve CLI text output when printing empty lists

["Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>]

CLI tools that use '--output-format text' and print empty lists now
show a 'No results' message. Previously, this was sometimes confusing
because nothing was printed.

Signed-off-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
---
 proxmox-router/src/cli/text_table.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/proxmox-router/src/cli/text_table.rs b/proxmox-router/src/cli/text_table.rs
index 34173b4d..6109d36f 100644
--- a/proxmox-router/src/cli/text_table.rs
+++ b/proxmox-router/src/cli/text_table.rs
@@ -788,7 +788,7 @@ fn extract_one_of_variant_properties(
 
 /// Format data using TableFormatOptions
 pub fn value_to_text<W: Write>(
-    output: W,
+    mut output: W,
     data: &mut Value,
     schema: &Schema,
     options: &TableFormatOptions,
@@ -820,6 +820,7 @@ pub fn value_to_text<W: Write>(
                 None => bail!("got unexpected data (expected array)."),
             };
             if list.is_empty() {
+                output.write_all(b"No results\n")?;
                 return Ok(());
             }
 
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel