all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] cfg2cmd: avoid using some x86 properties on other archs
@ 2025-01-13 13:56 Fiona Ebner
  0 siblings, 0 replies; only message in thread
From: Fiona Ebner @ 2025-01-13 13:56 UTC (permalink / raw)
  To: pve-devel

As reported in the enterprise support, using arch aarch64 for a VM in
combination with a new enough Windows ostype would fail:

> qemu-system-aarch64: warning: driftfix 'slew' is not available with this machine
> qemu-system-aarch64: Property 'virt-5.1-machine.hpet' not found

Conditionalize setting these properties that only exist for x86(_64)
according to the QEMU sources (and tested for aarch64 and riscv64).

Reported-by: Hannes Dürr <h.duerr@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5cde94a1..43008f3f 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3901,10 +3901,10 @@ sub config_to_command {
 
     if ($winversion >= 6) {
 	push @$globalFlags, 'kvm-pit.lost_tick_policy=discard';
-	push @$machineFlags, 'hpet=off';
+	push @$machineFlags, 'hpet=off' if $arch eq 'x86_64';
     }
 
-    push @$rtcFlags, 'driftfix=slew' if $tdf;
+    push @$rtcFlags, 'driftfix=slew' if $tdf && $arch eq 'x86_64';
 
     if ($conf->{startdate} && $conf->{startdate} ne 'now') {
 	push @$rtcFlags, "base=$conf->{startdate}";
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-01-13 13:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-13 13:56 [pve-devel] [PATCH qemu-server] cfg2cmd: avoid using some x86 properties on other archs Fiona Ebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal