From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] cfg2cmd: avoid using some x86 properties on other archs
Date: Mon, 13 Jan 2025 14:56:38 +0100 [thread overview]
Message-ID: <20250113135638.88099-1-f.ebner@proxmox.com> (raw)
As reported in the enterprise support, using arch aarch64 for a VM in
combination with a new enough Windows ostype would fail:
> qemu-system-aarch64: warning: driftfix 'slew' is not available with this machine
> qemu-system-aarch64: Property 'virt-5.1-machine.hpet' not found
Conditionalize setting these properties that only exist for x86(_64)
according to the QEMU sources (and tested for aarch64 and riscv64).
Reported-by: Hannes Dürr <h.duerr@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5cde94a1..43008f3f 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3901,10 +3901,10 @@ sub config_to_command {
if ($winversion >= 6) {
push @$globalFlags, 'kvm-pit.lost_tick_policy=discard';
- push @$machineFlags, 'hpet=off';
+ push @$machineFlags, 'hpet=off' if $arch eq 'x86_64';
}
- push @$rtcFlags, 'driftfix=slew' if $tdf;
+ push @$rtcFlags, 'driftfix=slew' if $tdf && $arch eq 'x86_64';
if ($conf->{startdate} && $conf->{startdate} ne 'now') {
push @$rtcFlags, "base=$conf->{startdate}";
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2025-01-13 13:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113135638.88099-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.