[pdm-devel] [PATCH proxmox-api-types 1/4] verifiers: Remove manual contains() implementation

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Fixes the manual_range_contains clippy lint:

warning: manual `!RangeInclusive::contains` implementation
   --> lib/proxmox-api-types/pve-api-types/src/types/verifiers.rs:200:12
    |
200 |         if vid > 4094 || vid < 2 {
    |            ^^^^^^^^^^^^^^^^^^^^^ help: use: `!(2..=4094).contains(&vid)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
    = note: `#[warn(clippy::manual_range_contains)]` on by default

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 pve-api-types/src/types/verifiers.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pve-api-types/src/types/verifiers.rs b/pve-api-types/src/types/verifiers.rs
index e17e190..004db9e 100644
--- a/pve-api-types/src/types/verifiers.rs
+++ b/pve-api-types/src/types/verifiers.rs
@@ -199,10 +199,10 @@ pub fn verify_pve_lxc_dev_string(s: &str) -> Result<(), Error> {
 
 pub fn verify_vlan_id_or_range(s: &str) -> Result<(), Error> {
     let check_vid = |vid: u16| -> Result<(), Error> {
-        if vid > 4094 || vid < 2 {
-            bail!("invalid VLAN tag '{vid}'");
-        } else {
+        if (2..=4094).contains(&vid) {
             Ok(())
+        } else {
+            bail!("invalid VLAN tag '{vid}'");
         }
     };
 
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel