From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 pve-common 00/12] Introduce and Package PVE::Path & PVE::Filesystem
Date: Thu, 9 Jan 2025 15:48:06 +0100 [thread overview]
Message-ID: <20250109144818.430185-1-m.carrara@proxmox.com> (raw)
Introduce and Package PVE::Path & PVE::Filesystem - v3
======================================================
Notable Changes Since v2
------------------------
- Mention that `path_components` will contain a '/' component at the
beginning of the returned list if the passed path is absolute
- Note behaviour regarding absolute paths being passed to `path_join` in
its docstring and refer to `path_push`
- Add a little extra info regarding parent path references and symlinks
in docstring of `path_parent`
- Don't return reference to list in scalar context anymore
Many thanks to Wolfgang for the great review and feedback! [1]
References
----------
[1]: https://lore.proxmox.com/pve-devel/s7he5i3khrtkja3ozl34tgoue7m4xnrvqhydnhcg67xp54zrgw@dnd37ovkjfqt/
Older Versions
--------------
v1: https://lore.proxmox.com/pve-devel/20241219183143.526267-1-m.carrara@proxmox.com/
v2: https://lore.proxmox.com/pve-devel/20241220185207.519912-1-m.carrara@proxmox.com/
Summary of Changes
------------------
Max Carrara (12):
introduce PVE::Path
test: add directory for tests of PVE::Path module
test: add tests for path_is_absolute and path_is_relative of PVE::Path
test: add tests for path_components of PVE::Path
test: add tests for path_join of PVE::Path
test: add tests for path_push of PVE::Path
test: add tests for path_parent of PVE::Path
test: add tests for path_starts_with, path_ends_with, path_equals
test: add test for file path operation functions of PVE::Path
test: add tests for path_normalize of PVE::Path
introduce PVE::Filesystem
debian: introduce package libproxmox-fs-path-utils-perl
debian/control | 6 +
debian/libproxmox-fs-path-utils-perl.install | 2 +
debian/libpve-common-perl.install | 29 +
src/Makefile | 2 +
src/PVE/Filesystem.pm | 78 ++
src/PVE/Path.pm | 991 ++++++++++++++
test/Makefile | 5 +-
test/Path/Makefile | 24 +
test/Path/path_comparison_tests.pl | 851 ++++++++++++
test/Path/path_components_tests.pl | 162 +++
test/Path/path_file_ops_tests.pl | 1226 ++++++++++++++++++
test/Path/path_is_absolute_relative_tests.pl | 122 ++
test/Path/path_join_tests.pl | 310 +++++
test/Path/path_normalize_tests.pl | 176 +++
test/Path/path_parent_tests.pl | 153 +++
test/Path/path_push_tests.pl | 159 +++
16 files changed, 4295 insertions(+), 1 deletion(-)
create mode 100644 debian/libproxmox-fs-path-utils-perl.install
create mode 100644 debian/libpve-common-perl.install
create mode 100644 src/PVE/Filesystem.pm
create mode 100644 src/PVE/Path.pm
create mode 100644 test/Path/Makefile
create mode 100755 test/Path/path_comparison_tests.pl
create mode 100755 test/Path/path_components_tests.pl
create mode 100755 test/Path/path_file_ops_tests.pl
create mode 100755 test/Path/path_is_absolute_relative_tests.pl
create mode 100755 test/Path/path_join_tests.pl
create mode 100755 test/Path/path_normalize_tests.pl
create mode 100755 test/Path/path_parent_tests.pl
create mode 100755 test/Path/path_push_tests.pl
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-01-09 14:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 14:48 Max Carrara [this message]
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 01/12] introduce PVE::Path Max Carrara
2025-01-31 12:23 ` Fiona Ebner
2025-01-31 12:33 ` Fiona Ebner
2025-02-03 14:21 ` Max Carrara
2025-02-03 15:42 ` Fiona Ebner
2025-02-03 16:45 ` Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 02/12] test: add directory for tests of PVE::Path module Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 03/12] test: add tests for path_is_absolute and path_is_relative of PVE::Path Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 04/12] test: add tests for path_components " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 05/12] test: add tests for path_join " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 06/12] test: add tests for path_push " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 07/12] test: add tests for path_parent " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 08/12] test: add tests for path_starts_with, path_ends_with, path_equals Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 09/12] test: add tests for file path operation functions of PVE::Path Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 10/12] test: add tests for path_normalize " Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 11/12] introduce PVE::Filesystem Max Carrara
2025-01-31 12:44 ` Fiona Ebner
2025-02-03 14:21 ` Max Carrara
2025-01-09 14:48 ` [pve-devel] [PATCH v3 pve-common 12/12] debian: introduce package libproxmox-fs-path-utils-perl Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109144818.430185-1-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.